Bug 518500 - Improve file indicators in Git staging view
Summary: Improve file indicators in Git staging view
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 05:33 EDT by David Weiser CLA
Modified: 2017-06-20 05:56 EDT (History)
3 users (show)

See Also:

Attachments
visual studio code git (20.41 KB, image/jpeg)
2017-06-20 05:33 EDT, David Weiser CLA 		no flags Details
EGit icon decorators (11.91 KB, image/png)
2017-06-20 05:34 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Weiser CLA 2017-06-20 05:33:06 EDT 
Created attachment 268973 [details]
visual studio code git

The file status indicators (deleted, added, untracked, etc) in the Git staging view could be improved. Check the screenshot from Visual Studio Code.
Comment 1 Lars Vogel CLA 2017-06-20 05:34:50 EDT 
Created attachment 268974 [details]
EGit icon decorators
Comment 2 Lars Vogel CLA 2017-06-20 05:36:04 EDT 
+1 looks way better in visual studio code.

Maybe EGit can use a different label provider for the staging view and use icon decorators "only" in project explorer / package explorer.
Comment 3 Thomas Wolf CLA 2017-06-20 05:39:56 EDT 
Not convinced at all. I don't think the VC visuals were better.
Comment 4 Lars Vogel CLA 2017-06-20 05:43:24 EDT 
(In reply to Thomas Wolf from comment #3)
> Not convinced at all. I don't think the VC visuals were better.

I like the color coding, red for deleted, green for added, etc.
For example, in EGit it is harder (for me) to identify the deleted resources.
Comment 5 Thomas Wolf CLA 2017-06-20 05:56:33 EDT 
(In reply to Lars Vogel from comment #4)
> (In reply to Thomas Wolf from comment #3)
> > Not convinced at all. I don't think the VC visuals were better.
> 
> I like the color coding, red for deleted, green for added, etc.
> For example, in EGit it is harder (for me) to identify the deleted resources.

Color-coding alone is dangerous (red-green blindness). Which is why VC has the character, too. (BTW, what's "U"? "unchanged"? Those don't even appear in our staging view.

Using the standard Eclipse mechanisms also shows error and warning markers and ensures a uniform UI experience. We should not change that.

Perhaps we can *additionally* try to distinguish individual files' states in the staging view. Such as using strike-through for deleted resources. But personally I find that hard to read.