Bug 517709 - Dark Theme: HTML-Links in Java Hovers hardly readable in Dark Theme
Summary: Dark Theme: HTML-Links in Java Hovers hardly readable in Dark Theme
Status: CLOSED DUPLICATE of bug 517393
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-02 07:58 EDT by Matthias Becker CLA
Modified: 2017-06-02 12:46 EDT (History)
2 users (show)

See Also:

Attachments
Current situation (161.55 KB, image/png)
2017-06-02 07:58 EDT, Matthias Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Becker CLA 2017-06-02 07:58:09 EDT 
Created attachment 268715 [details]
Current situation

The java doc hovers render HTML links in dark blue. In the dark theme this is hardly readable. You can see this in the attached screenshot.
The cause it that: org.eclipse.jdt.ui/JavadocViewStyleSheet.css and org.eclipse.jdt.ui/JavadocHoverStyleSheet.css contains hard-codes colors
like:  
  a:link	     { color: #0000FF; }

These colors need to be replaced at runtime dependent on the Theme e.g. with
  JFaceColors.getHyperlinkText(..)

I think something similar is needed for these colors as 
 org.eclipse.jface.internal.text.html.HTMLPrinter#convertTopLevelFont
does it with the font attributes.
Comment 1 Dani Megert CLA 2017-06-02 09:35:24 EDT 

*** This bug has been marked as a duplicate of bug 517393 ***
Comment 2 Leo Ufimtsev CLA 2017-06-02 12:46:36 EDT 
> The cause it that: org.eclipse.jdt.ui/JavadocViewStyleSheet.css and
> org.eclipse.jdt.ui/JavadocHoverStyleSheet.css contains hard-codes colors
> like:  
>   a:link	     { color: #0000FF; }
> 
> These colors need to be replaced at runtime dependent on the Theme e.g. with
>   JFaceColors.getHyperlinkText(..)
> 
> I think something similar is needed for these colors as 
>  org.eclipse.jface.internal.text.html.HTMLPrinter#convertTopLevelFont
> does it with the font attributes.

Thank you for pointing to these, that's useful.