Bug 517647 - ${eclipse.pdebuild.scripts} is not set
Summary: ${eclipse.pdebuild.scripts} is not set
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 major with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-01 10:33 EDT by Sassan Ashkan Far CLA
Modified: 2023-03-30 18:00 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sassan Ashkan Far CLA 2017-06-01 10:33:07 EDT
It seems the property ${eclipse.pdebuild.scripts} is not properly set, causing any product export (both headless and with wizard) to fail when generating p2 metadata repository.

(Using eclipse.buildId=4.7.0.I20170518-1030 and Java 8)
Comment 1 Sassan Ashkan Far CLA 2017-06-01 10:41:33 EDT
From the configuration:
org.eclipse.pde.build (3.9.300.v20170515-0912) "Plug-in Development Environment Build Support" [Active]
Comment 2 Vikas Chandra CLA 2017-06-02 03:01:35 EDT
Did this work in 4.6 or 4.5?

PDE is in maintenance mode and in Oxygen, there has hardly been any code change.
Comment 3 Sassan Ashkan Far CLA 2017-06-02 04:14:00 EDT
(In reply to Vikas Chandra from comment #2)
> Did this work in 4.6 or 4.5?
> 
> PDE is in maintenance mode and in Oxygen, there has hardly been any code
> change.

Yes, exporting the same workspace with Neon 3 (eclipse.buildId=4.6.3.M20170301-0400) works fine.
Comment 4 Sassan Ashkan Far CLA 2017-06-08 08:59:03 EDT
Any update on this?
Comment 5 Vikas Chandra CLA 2017-06-19 03:23:30 EDT
Since this came very late, I will investigate this for 4.7.1.

Also moving bug to major since it has been reported just once (and PDE build is in maintenance mode).
Comment 6 Chin Bim CLA 2017-07-18 16:35:03 EDT
I can confirm this bug. 

4.6.3 works fine for me.

In 4.7 the build fails immediately with the error:

build:
     [echo] Compiling Product overdrive.server...
     [java] Buildfile: C:\Eclipse Target\Eclipse\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\productBuild.xml
     [java] 
     [java] BUILD FAILED
     [java] C:\Eclipse Target\Eclipse\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\productBuild.xml:18: Cannot find C:\Eclipse Target\Eclipse\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\${eclipse.pdebuild.scripts}\build.xml imported from C:\Eclipse Target\Eclipse\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\productBuild.xml
Comment 7 Vikas Chandra CLA 2017-08-22 01:56:55 EDT
Move to 4.7.2
Comment 8 Sassan Ashkan Far CLA 2017-10-02 04:04:52 EDT
(In reply to Vikas Chandra from comment #7)
> Move to 4.7.2

Are you looking into this now? That would be very nice.
Comment 9 Lonnie VanZandt CLA 2017-10-23 13:09:21 EDT
(In reply to Vikas Chandra from comment #7)
> Move to 4.7.2

Any ETA for resolution or for a workaround?
Comment 10 Lonnie VanZandt CLA 2017-10-23 13:18:38 EDT
(In reply to Lonnie VanZandt from comment #9)
> (In reply to Vikas Chandra from comment #7)
> > Move to 4.7.2
> 
> Any ETA for resolution or for a workaround?

Selfie: track down the location of the PDE scripts, get the absolute path, set the property explicitly to this in the productBuild.xml file, AND replace the parameterized import path with the absolute path. The last step is necessary because in Ant, file importing is parsed before property expansions.

And, wait for 4.8?
Comment 11 Chin Bim CLA 2018-02-06 10:47:01 EST
Is there any update on this? It is a deal breaker that prevents us from moving to 4.7.
Comment 12 Vikas Chandra CLA 2018-02-07 01:36:00 EST
PDE build is in maintenance mode. I need to prioritize this one. Meanwhile if there is a quality patch from anyone, I will push it in after some testing and review.
Comment 13 Chin Bim CLA 2018-02-07 11:39:56 EST
This is a regression, since it worked in 4.6.3 but not 4.7. Something must have changed during that time.
Comment 14 Peter Pinnau CLA 2018-02-20 10:11:29 EST
I can confirm the problem, too. I tried to migrate from 4.6. to 4.7. and product exports terminate with:

genericTargets.xml:237: A problem occured while invoking the director

The mentioned workaround does not work for me.


I moved forward and gave maven tycho a chance. As far as I understand tycho is the current E4-technology for building plugins, features and products. PDE will be outdated.

Howto:
http://www.vogella.com/tutorials/EclipseTycho/article.html

After first reading I needed a cup of coffee and just asked "Why does that happen? ;)" but after 1,5 hours of work the export now works for my product consisting of 4 plugins.

So my suggestion is to spend time for upgrading to tycho instead of trying to get the old stuff working.
Comment 15 Vikas Chandra CLA 2018-04-18 05:21:15 EDT
Bulk move out of 4.8 target milestone.
Comment 16 Altern Ken CLA 2018-08-21 03:03:14 EDT
Hi guys, 

Any update on this topic?

Currently i am facing the same issuer,
Migrate from Eclipse 4.4.2 to Eclipse 4.7.3a

The error :
BUILD FAILED
2018-08-20T05:54:35.0439551Z      [java] C:\Program Files\Eclipse 4.7\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\productBuild.xml:18: 
Cannot find C:\Program Files\Eclipse 4.7\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\build.xml 
imported from C:\Program Files\Eclipse 4.7\plugins\org.eclipse.pde.build_3.9.300.v20170515-0912\scripts\productBuild\productBuild.xml
Comment 17 Altern Ken CLA 2018-08-23 21:50:59 EDT
Hi, 

I try remove all the spacing in the Eclipse path and it can run without any error now.

Example : C:/Eclipse47

Hope it helps someone.
Comment 18 Kai Chu CLA 2019-04-18 07:51:45 EDT
This should have been fixed in next release 4.9M2 by case:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532618

The problem is spaces in the path are not allowed before this fix
https://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/org.eclipse.pde.build/src/org/eclipse/pde/internal/build/properties/PDEProperties.java?id=a1d12846c9a479da6469ab6365a7fe975ecce032

As Altern Ken said, put your eclipse in the path without any space will solve the problem before you got the fix.
Comment 19 Eclipse Genie CLA 2021-04-08 01:35:11 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 20 Eclipse Genie CLA 2023-03-30 18:00:40 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.