Bug 517398 - [Usability][CommonDiagram] Cannot save grid preferences to disable layout snapping
Summary: [Usability][CommonDiagram] Cannot save grid preferences to disable layout sna...
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.0.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-29 14:01 EDT by Christian Damus CLA
Modified: 2017-08-07 08:23 EDT (History)
1 user (show)

See Also:


Attachments
Invalid initial font preferences in new workspace (59.99 KB, image/png)
2017-06-08 09:54 EDT, Christian Damus CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2017-05-29 14:01:05 EDT
Papyrus 3.0 RC1

The diagram preferences for showing and snapping to grid in new diagrams are on by default.  I don't want the grid in any of my diagrams.  Accordingly, I try to uncheck both of these settings in the preference page but my preference is never stored because of an exception in the page.

Steps to reproduce:

1.  Open the Eclipse Preferences dialog.
2.  Go to the "Papyrus -> Diagrams" page.
3.  Uncheck both "Show grid for new diagrams" and "Snap to grid for new diagrams".
4.  Press "Apply".
5.  See an exception in the log (below).
6.  Switch to another preference page and back.
7.  See that these preferences are both still selected.

The exception suggests that some numeric input field is blank.  But AFAICS, for my workspace, all of the fields in this page that require numbers have perfectly decent positive integers in them, except for "Transparency" which has a zero and is disabled anyways.

!ENTRY org.eclipse.ui 4 0 2017-05-29 13:52:43.449
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NumberFormatException: For input string: ""
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Integer.parseInt(Integer.java:592)
	at java.lang.Integer.parseInt(Integer.java:615)
	at org.eclipse.papyrus.infra.gmfdiag.preferences.jface.preference.FontFieldEditor.doStore(FontFieldEditor.java:143)
	at org.eclipse.jface.preference.FieldEditor.store(FieldEditor.java:676)
	at org.eclipse.papyrus.infra.ui.preferences.AbstractPreferenceGroup.storePreferences(AbstractPreferenceGroup.java:159)
	at org.eclipse.papyrus.infra.ui.preferences.AbstractPapyrusPreferencePage.storePreferences(AbstractPapyrusPreferencePage.java:166)
	at org.eclipse.papyrus.infra.ui.preferences.AbstractPapyrusPreferencePage.storeAllPreferences(AbstractPapyrusPreferencePage.java:176)
	at org.eclipse.papyrus.infra.gmfdiag.preferences.pages.PapyrusAllDiagramsPreferencePage.storeAllPreferences(PapyrusAllDiagramsPreferencePage.java:146)
	at org.eclipse.papyrus.infra.ui.preferences.VisiblePageSingleton.store(VisiblePageSingleton.java:66)
	at org.eclipse.papyrus.infra.ui.preferences.AbstractPapyrusPreferencePage.performOk(AbstractPapyrusPreferencePage.java:156)
	at org.eclipse.jface.preference.PreferencePage.performApply(PreferencePage.java:454)
	at ...
Comment 1 Fanch Bonnabesse CLA 2017-06-07 04:36:08 EDT
Hi Christian,

I can not reproduce the bug on my side.

Can you try to click on "Restore Defaults" and try again the same steps please ?

The fieldin error appears to be "Font" at the top of the page.
Comment 2 Christian Damus CLA 2017-06-08 09:54:14 EDT
Created attachment 268820 [details]
Invalid initial font preferences in new workspace

It's possible that this is only reproducible on Mac platform.

In a new workspace, the initial font preferences in the "Papyrus -> Diagrams" page are as attached.  Note:

1. The font size pick-list has the expected choices, but none is selected.
2. The initial font selection looks like nonsense.  Yes, it's the Mac standard San Francisco font, but it should be have a more user-friendly presentation.

Item 1 above is the cause of the exception.  It is easy not to notice the font settings problem when one is focused on other diagram preferences, and there is nothing when dismissing the Preferences dialog to indicate that actually no changes were saved, even unrelated to the font.

This is on a Mac OS Sierra (10.12.5) system.