517071 – [tests] random fail in JavaThreadEventHandlerTests.testComputeFrameIndexDuringEvaluation()

Bug 517071 - [tests] random fail in JavaThreadEventHandlerTests.testComputeFrameIndexDuringEvaluation()

Summary: [tests] random fail in JavaThreadEventHandlerTests.testComputeFrameIndexDurin...

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Debug (show other bugs)
Version:	4.7
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.7 RC2
Assignee:	Andrey Loskutov
QA Contact:

URL:
Whiteboard:
Keywords:	test

Depends on:
Blocks:

Reported:	2017-05-22 08:33 EDT by Andrey Loskutov
Modified:	2017-05-30 07:17 EDT (History)
CC List:	2 users (show)

See Also:	515206 Gerrit Change Git Commit

Flags:	sarika.sinha: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Loskutov

2017-05-22 08:33:46 EDT

See bug 515206 comment 3.
junit.framework.AssertionFailedError: expected:<0> but was:<-1>
at org.eclipse.jdt.debug.tests.breakpoints.JavaThreadEventHandlerTests$1.performChecks(JavaThreadEventHandlerTests.java:157)

The problem here is the timing, if the evaluation thread runs longer then we expect, we will still see -1 as index. I think we can simply tune the test assumptions to make it more stable.

Comment 1 Andrey Loskutov

2017-05-22 08:34:33 EDT

@Sarika, I have a patch. Can we merge it for 4.7?

Comment 2 Eclipse Genie

2017-05-22 08:40:04 EDT

New Gerrit change created: https://git.eclipse.org/r/97678

Comment 3 Sarika Sinha

2017-05-22 23:51:41 EDT

+1 for RC2

Released the changes.

Comment 4 Eclipse Genie

2017-05-22 23:51:46 EDT

Gerrit change https://git.eclipse.org/r/97678 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=8a8973d7ac919aebce0904de65066f79ab10c0f2

Comment 5 Andrey Loskutov

2017-05-30 07:17:19 EDT

Let say it is verified, at least we haven't seen it anymore since the fix. Works with I20170529-2000, zero fails in jdt.debug tests
http://download.eclipse.org/eclipse/downloads/drops4/I20170529-2000/testResults.php.