Bug 516706 - Problems view:Configure problem severity quick fix must be at the end
Summary: Problems view:Configure problem severity quick fix must be at the end
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7.1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 517052
Blocks:
  Show dependency tree
 
Reported: 2017-05-16 06:49 EDT by Dani Megert CLA
Modified: 2017-08-18 05:24 EDT (History)
0 users

See Also:

Attachments
Patch - WIP (2.53 KB, application/octet-stream)
2017-05-16 08:53 EDT, Vikas Chandra CLA 		no flags Details
Patch PDE - WIP (15.44 KB, patch)
2017-05-16 09:00 EDT, Vikas Chandra CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2017-05-16 06:49:40 EDT 
The Configure problem severity quick fix must be at the end. This works fine in the manifest.mf but not when invoking the quick fix via Problems view.

Example:
/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
The value for attribute 'Bundle-Name' is not externalized.  The value must begin with %
Comment 1 Vikas Chandra CLA 2017-05-16 08:53:44 EDT 
Created attachment 268373 [details]
Patch - WIP

This requires a new interface in org.eclipse.ui.internal.views.markers.
Plugin: org.eclipse.ui.ide
Or add a new method to existing interface for getting relevance.
Comment 2 Vikas Chandra CLA 2017-05-16 09:00:43 EDT 
Created attachment 268374 [details]
Patch PDE - WIP
Comment 3 Vikas Chandra CLA 2017-05-16 09:06:29 EDT 
Applying the two patches ensures that comment#0 is fixed for PDE compiler as well as API tools errors.

However we need to have more discussion

a) Add a new interface or add new method to IMarkerResolution (API change or addition)
b) Preference to user
Comment 4 Dani Megert CLA 2017-05-16 10:20:45 EDT 
(In reply to Vikas Chandra from comment #1)
> Created attachment 268373 [details]
> Patch - WIP
> 
> This requires a new interface in org.eclipse.ui.internal.views.markers.
> Plugin: org.eclipse.ui.ide
> Or add a new method to existing interface for getting relevance.

This requires a separate bug report in Platform UI.
Comment 5 Vikas Chandra CLA 2017-05-17 06:43:01 EDT 
>>This requires a separate bug report in Platform UI.

I will open a bug either today or tomorrow ( after Rc1 related work)
Comment 6 Vikas Chandra CLA 2017-05-22 04:43:38 EDT 
>I will open a bug either today or tomorrow

Sorry for the delay.

Opened Bug 517052 with my proposed solution in platform.ide.

This bug now depends on Bug 517052
Comment 7 Vikas Chandra CLA 2017-07-11 05:24:16 EDT 
Once the patch at bug 517052 is accepted, we can go ahead with this fix.
Comment 8 Eclipse Genie CLA 2017-07-15 14:09:12 EDT 
New Gerrit change created: https://git.eclipse.org/r/101310
Comment 9 Eclipse Genie CLA 2017-07-18 03:50:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/101408
Comment 11 Vikas Chandra CLA 2017-07-31 11:46:16 EDT 
Verified in

Version: Photon (4.8)
Build id: I20170730-2000

for a manifest compiler error as well as an api tool error.

Keeping this bug open for backport to 4.7.1
Comment 12 Eclipse Genie CLA 2017-08-04 04:17:04 EDT 
New Gerrit change created: https://git.eclipse.org/r/102513
Comment 13 Eclipse Genie CLA 2017-08-07 04:52:23 EDT 
Gerrit change https://git.eclipse.org/r/102513 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=b3dd686265cd877f8bd8dae053a96a09dec67d0c
Comment 14 Vikas Chandra CLA 2017-08-18 05:24:28 EDT 
verified on
Version: Oxygen.1 (4.7.1)
Build id: M20170816-0500