Bug 516656 - Umlauts get mangled in class files in product jars
Summary: Umlauts get mangled in class files in product jars
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-15 10:24 EDT by Olaf Bigalk CLA
Modified: 2022-11-14 12:10 EST (History)
2 users (show)

See Also:


Attachments
Projects demonstrating the issue (6.51 KB, application/zip)
2017-05-15 10:24 EDT, Olaf Bigalk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Bigalk CLA 2017-05-15 10:24:13 EDT
Created attachment 268340 [details]
Projects demonstrating the issue

I have discovered that umlauts in string constants get mangled (misencoded) in the class file that are produced for jars that are produced for an eclipse product.

I have attached a zip with a plugin and a product project. The plugin project contains one class that only defines an string constant containing all umlauts.
The product project contains a product file referencing only the plugin project.

The umlauts are well in the plugin projects class file but when it is moved to the procucts plugin repository the encoding of the class file gets messed up in the resulting jar file.

The issue exists only on the Windows platform, on the linux platform all is all right.
Comment 1 Hannes Erven CLA 2017-05-19 20:45:37 EDT
Just came across this issue.

My source code is in UTF-8 and some class names or enum constant have Umlauts (ä,ö,ß) in their names. While this might arguably be a bad practice, it's legacy in that project and I have to live with it.


The "Export Product wizard" (RCP) as well as the Libra WAR Export (RAP) fail with compile errors.


Example:
392. ERROR in <SOURCEFILE>.java (at line 43)
	private TAG(String foo, String abkürzung, int id){

Syntax error on token "Invalid Character", < expected


This clearly is a regression - that worked on Neon. For me, this is a major showstopper blocking any transition to Oxygen.
Comment 2 Hannes Erven CLA 2017-05-20 16:39:58 EDT
Upon further investigation I found that this is NOT A REGRESSION: my Neon installs all had the following change applied to eclipse.ini:

in the "-vmargs" section, add:
-Dfile.encoding=UTF-8

Without that setting, the PDE exports also fail on Neon.
With the setting added, the exports also succeed in Oxygen.


I'd still say it is a bug that the PDE exports do not honor the resource encoding specified in the workspace (either project or resource wise)...
Comment 3 Vikas Chandra CLA 2017-05-22 03:43:05 EDT
Can you get details steps for export?
Comment 4 Olaf Bigalk CLA 2017-05-22 17:28:38 EDT
If you open the product file open the overview page and click on "Eclipse Product export wizard". That's all.
Comment 5 Lars Vogel CLA 2018-12-03 09:10:34 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 6 Lars Vogel CLA 2018-12-03 09:10:38 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 7 Eclipse Genie CLA 2020-11-23 15:08:16 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Eclipse Genie CLA 2022-11-14 12:10:40 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.