Bug 516593 - HTML pages should specify a default language
Summary: HTML pages should specify a default language
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 13.0   Edit
Hardware: PC Mac OS X
: P2 normal (vote)
Target Milestone: 15.0   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2017-05-12 13:09 EDT by Michael Rennie CLA
Modified: 2017-05-12 14:19 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2017-05-12 13:09:54 EDT 
Our HTML elements must specify a default page language to conform to the BCP 47 accessibility spec.

For example the Operations, Editor, Git and Settings HTML pages do not have 'lang="en"' set on them.

See https://tools.ietf.org/html/bcp47 for all the gritty details.
Comment 1 Michael Rennie CLA 2017-05-12 13:22:35 EDT 
Pushed part 1 of the fix:

https://github.com/eclipse/orion.client/commit/c5d95efcea943e1881b3e848006153faf48670a2

the remaining work is to finish going through all HTML pages to determine if they could be reachable from the Orion UI, and if so, must have a default language provided.
Comment 2 Michael Rennie CLA 2017-05-12 14:19:33 EDT 
The rest of the changes:

https://github.com/eclipse/orion.client/commit/59e264ebfda65cbd32585f0409038a5b8fb979ab

I also added the default language property to the JS test pages.