Bug 515818 - Disable toolbar actions if no diff is visible/selected
Summary: Disable toolbar actions if no diff is visible/selected
Status: ASSIGNED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Martin Fleck CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-26 05:49 EDT by Martin Fleck CLA
Modified: 2017-05-05 08:48 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fleck CLA 2017-04-26 05:49:29 EDT
When opening a comparison that does not have any differences or has all differences filtered from the editor, the toolbar still offers actions to merge diffs and to navigate between diffs:
- Copy current change from left to right
- Copy current change from right to left
- Apply all left changes on the right-hand side
- Apply all left changes on the left-hand side
- Next difference
- Previous difference

Copying single changes and navigating diffs result in NPEs and applying all changes simply does nothing.

Instead, these actions should be disabled to communicate to the user that they are not available at the time.

Similarly, the copy current change actions should be disabled when no current change is selected.
Comment 1 Eclipse Genie CLA 2017-04-26 05:58:55 EDT
New Gerrit change created: https://git.eclipse.org/r/95769