Bug 515704 - Current instruction pointer incorrect when CSourceNotFound editor is open
Summary: Current instruction pointer incorrect when CSourceNotFound editor is open
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 9.3.0   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 515296
  Show dependency tree
 
Reported: 2017-04-24 12:09 EDT by Jonah Graham CLA
Modified: 2020-09-04 15:20 EDT (History)
4 users (show)

See Also:

Attachments
screenshot of bad arrows (50.80 KB, image/png)
2017-04-24 12:09 EDT, Jonah Graham CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2017-04-24 12:09:54 EDT 
Created attachment 267947 [details]
screenshot of bad arrows

The Current IP (Instruction Pointer) is incorrect when the top frame is CSourceNotFound.

See attachment: func2 is the top of the stack, but the solid blue arrow is drawn inside func1, the highest entry in the stack not represented by source not found editor. I expect arrow inside func1 to be outline blue as the one in main.
Comment 1 Jonah Graham CLA 2017-05-09 10:57:03 EDT 
I don't think this is going to be done for 9.3. The refactoring of DsfSourceDisplayAdapter and InstructionPointerManager would be too large to enable this fix for the value fixing it gives

As Pawel Piech said in Bug 269956 comment #1)
> DsfSourceDisplayAdapter was really just a prototype when I initially created
> it.  Would it be better to try to break up this adapter into components that
> could be extended?