Bug 515591 - Flaky test ResourceComputationSchedulerWithEventBusTest.testDemandShutdownWithLongRunningTaskThatInterruptsGracefully
Summary: Flaky test ResourceComputationSchedulerWithEventBusTest.testDemandShutdownWit...
Status: REOPENED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Team (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-21 11:08 EDT by Philip Langer CLA
Modified: 2017-09-08 05:15 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Langer CLA 2017-04-21 11:08:35 EDT 
It seems that the test ResourceComputationSchedulerWithEventBusTest.testDemandShutdownWithLongRunningTaskThatInterruptsGracefully is flaky. I had a test failure in master-build-on-egit-logical-nightly #551, retriggered it, and #552 went through.

The failure trace was as follows:

java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.eclipse.emf.compare.ide.ui.tests.logical.resolver.ResourceComputationSchedulerWithEventBusTest.testDemandShutdownWithLongRunningTaskThatInterruptsGracefully(ResourceComputationSchedulerWithEventBusTest.java:280)
Comment 1 Laurent Goubet CLA 2017-09-07 11:12:11 EDT 
I don't think I've seen this failure yet, has it been reproduced somehow?
Comment 2 Philip Langer CLA 2017-09-07 11:15:56 EDT 
I have never succeeded to reproduce it locally, but it indeed happened very recently on the master-gerrit build:
https://hudson.eclipse.org/emfcompare/job/master-gerrit/3352/PLATFORM=mars,jdk=JDK_1.8.0_Latest/
Comment 3 Laurent Goubet CLA 2017-09-07 11:18:22 EDT 
I was just wiping the workspace for the master-build-on-gerrit-logical-nightly to test :)

So this indeed still happens, looking at the code though, I'm not sure how we can ensure it won't... or if it's somehow revealing an underlying bug-in-waiting in our code
Comment 4 Eclipse Genie CLA 2017-09-07 11:39:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/104665
Comment 5 Laurent Goubet CLA 2017-09-07 11:40:08 EDT 
I'll increase the scheduler's timeout from 10ms to 100ms to see if this solves things.
Comment 7 Laurent Goubet CLA 2017-09-07 11:59:27 EDT 
Closing for now, will reopen if we reproduce again
Comment 8 Laurent Goubet CLA 2017-09-08 05:15:33 EDT 
Reproduced again with https://hudson.eclipse.org/emfcompare/job/master-gerrit/3352/

We need to debug through this test and find a way to ensure the scheduled computation is properly interrupted before the scheduler times it out.