Bug 515429 - [painting] Matching Bracket border should be thicker
Summary: [painting] Matching Bracket border should be thicker
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 05:05 EDT by Lars Vogel CLA
Modified: 2017-04-20 09:30 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2017-04-19 05:05:22 EDT
With Bug 52067 the matching bracket color has been improved. IMHO it is still hard to see. 

I suggest to make the border a bit thicker (1-2 pixel) to increase its visibility.
Comment 1 Dani Megert CLA 2017-04-19 08:45:24 EDT
Out of the box I'd say -1, but I'd be willing to look at it once it is implemented.
Comment 2 Stephan Herrmann CLA 2017-04-20 05:38:57 EDT
Why not solid background instead of a frame (of whatever thickness)?
Is it because we cannot find a color that works in all situations (incl like highlighting)?
Comment 3 Lars Vogel CLA 2017-04-20 06:25:20 EDT
(In reply to Stephan Herrmann from comment #2)
> Why not solid background instead of a frame (of whatever thickness)?
> Is it because we cannot find a color that works in all situations (incl like
> highlighting)?

+1 for solid color
Comment 4 Stephan Herrmann CLA 2017-04-20 07:54:44 EDT
(In reply to Stephan Herrmann from comment #2)
> Why not solid background instead of a frame (of whatever thickness)?
> Is it because we cannot find a color that works in all situations (incl like
> highlighting)?

significant typo, should be: "incl. line highlighting".
Comment 5 Noopur Gupta CLA 2017-04-20 09:21:38 EDT
It is because the current API org.eclipse.ui.texteditor.SourceViewerDecorationSupport.setMatchingCharacterPainterPreferenceKeys(String enableKey, String colorKey, String highlightCharacterAtCaretLocationKey, String enclosingPeerCharactersKey) does not provide a way to specify the highlighting style.

The solution here would be to contribute the matching brackets highlight as an annotation type in Text Editors > Annotations preferences.
Comment 6 Dani Megert CLA 2017-04-20 09:30:58 EDT
(In reply to Stephan Herrmann from comment #2)
> Why not solid background instead of a frame (of whatever thickness)?
> Is it because we cannot find a color that works in all situations (incl like
> highlighting)?

Like using red color I find marking it via background is too intrusive. Also, it can collide with other background highlighting like current line, search results, current instructions pointer, etc.

As outlined in comment 5, changing the API to use an annotation and allow the user configure it would be a solution, but not something the JDT team has time to do.