515393 – [CSS] [Dark] Allow other to contribute to the org-eclipse-cdt-ui preference node via CSS

Bug 515393 - [CSS] [Dark] Allow other to contribute to the org-eclipse-cdt-ui preference node via CSS

Summary: [CSS] [Dark] Allow other to contribute to the org-eclipse-cdt-ui preference n...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-editor (show other bugs)
Version:	8.4.0
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	9.9.0
Assignee:	Jeff Johnston
QA Contact:	Anton Leherbauer

URL:
Whiteboard:
Keywords:	usability

Depends on:	433477
Blocks:	433475
	Show dependency tree

Reported:	2017-04-18 11:36 EDT by Lars Vogel
Modified:	2019-08-12 10:09 EDT (History)
CC List:	8 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2017-04-18 11:36:52 EDT

Before Bug 466075, extenders could not extend a preference CSS node without overriding the existing node.

Now that 466075 is fixed, this can be done, if you use pseudo attributes.

I recomment to add "org-eclipse-cdt-ui" to your preference node. See Bug 466075 for the details.

So you should change your core/org.eclipse.cdt.ui/css/e4-dark_cdt.css preference node to the following:

IEclipsePreferences#org-eclipse-cdt-ui:org-eclipse-cdt-ui { /* pseudo attribute added to allow contributions without replacing this node, see Bug 466075 */

Comment 1 Lars Vogel

2019-08-09 07:24:42 EDT

Jeff, could you do this for CDT to get this old bug closed?

Comment 2 Jeff Johnston

2019-08-09 13:36:55 EDT

(In reply to Lars Vogel from comment #1)
> Jeff, could you do this for CDT to get this old bug closed?

Ok

Comment 3 Eclipse Genie

2019-08-09 15:06:18 EDT

New Gerrit change created: https://git.eclipse.org/r/147396

Comment 4 Jonah Graham

2019-08-09 15:18:14 EDT

@Lars, does Jeff's fix for this mean that Bug 546610 can be resolved by providing some CSS? If so, can a similar thing be done to JDT, see Bug 537988.

Comment 5 Eclipse Genie

2019-08-09 16:27:39 EDT

Gerrit change https://git.eclipse.org/r/147396 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=bb602d0fb30606cda1368daab091e66bdf1dbc4d

Comment 6 Lars Vogel

2019-08-09 16:34:21 EDT

(In reply to Jonah Graham from comment #4)
> @Lars, does Jeff's fix for this mean that Bug 546610 can be resolved by
> providing some CSS? If so, can a similar thing be done to JDT, see Bug
> 537988.

I did the same for JDT a while ago

Comment 7 Jeff Johnston

2019-08-12 10:09:28 EDT

Patch merged to master.