Community
Participate
Working Groups
using eclips STS 3.7.2 + CFT 1.0.3 i noticed that some configurations in manifest.yml are ignored. for example this yml --- applications: - name: my-app disk_quota: 512M memory: 1024M instances: 1 health-check-type: port env: SPRING_PROFILES_ACTIVE : cloud services: - amaryRMQ the properties "disk_quota" and "health-check-type" are ignored when the app is started by CFT. on the other hand, changes in "memory" are working well. BTW, when using "cf push" all properties are configured properly.
Thanks for raising this bug. We will be adding support for many of the missing properties to the Eclipse Oxygen release (CFT 1.1.0) For our reference, I've compiled a list of missing properties: routes route hosts domains no-route no-hostname random-route health-check-type stack disk_quota inherit timeout command
Also, we can consider that for those properties that we may not be able to support for Oxygen, like "inherit", we can still parse and detect them, and maybe log a warning indicating that we do not support them.
Created attachment 267713 [details] manifest.yml compare in STS 3.8.4 I've upgraded to STS 3.8.4 and Cloud Foundry Tools - Version: 1.0.8.v201703012110 Now, I see that yml files are processed well. the plugin compare the local yml with the server one. I'm also able to see that line in the log when i change something: Updated app with guid aaaaa-aaaaaa ({"disk_quota"=>512, "environment_json"=>"PRIVATE DATA HIDDEN", "health_check_type"=>"none", "instances"=>1, "memory"=>512, "name"=>"XXXXX"})
GitHub Pull Request 60 created by [elsony] https://github.com/eclipse/cft/pull/60
GitHub Pull Request 63 created by [elsony] https://github.com/eclipse/cft/pull/63
Add the following to pull #63: 1. Added manifest support for disk_quota, timemout and command. 2. Added check for inherit to produce a warning log entry for manifest containing inherit entry. 3. Added stack support including selection UI on deployment dialog.
(In reply to Yariv Amar from comment #3) > Created attachment 267713 [details] > manifest.yml compare in STS 3.8.4 > > I've upgraded to STS 3.8.4 and > Cloud Foundry Tools - Version: 1.0.8.v201703012110 > > Now, I see that yml files are processed well. > the plugin compare the local yml with the server one. > I'm also able to see that line in the log when i change something: > Thanks for the additional information. That screenshot looks like it is from STS Spring Boot Dashboard, which is different from CFT, even though both co-exist in STS and both allow deploying to Cloud Foundry from STS. Here is more information about Boot Dashboard: https://spring.io/blog/2016/03/22/the-spring-boot-dashboard-in-sts-part-4-working-with-cloud-foundry-manifest-files Boot Dashboard is a Cloud Foundry deployment feature that is specific for Spring Boot applications in STS. It does provide a compare editor to detect manifest file differences, and it is the recommended way to deploy Spring Boot apps within STS, and it supports health check. We are updating CFT manifest support to also support health check and other missing manifest properties.
I've created a separate bugzilla for health check type and health check http endpoint here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=516772 Both require additional changes to the v1 CF Java client that CFT uses, so I feel it is better to track them separately. Since the CFT manifest parser now parses other missing properties, including disk_quota, maybe we can close this bugzilla as resolved, and continue with more specific cases like health check and health check http endpoint in separate bugzilla, which are still missing to be implemented in CFT.
I am marking this bug as resolved based on the comment #8. You can continue to track the health check type property support using bug 516772.
