Bug 5139 - Remove SnippetSupportBreakpoint
Summary: Remove SnippetSupportBreakpoint
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-22 11:17 EDT by Darin Wright CLA
Modified: 2001-11-13 11:18 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2001-10-22 11:17:18 EDT
SnippetSupprotBreakpoint will be removed from the debug model as API.
The snippet editor will use a "run-to-line" breakpoint instead, with 
a hit count of zero (so it is always hit, and does not appear in the
breakpoint view). 

The tricky part is that the IType supplied to create the breakpoint does
not exist in the workspace (i.e. it is a type in a the snippet support
jar). We will have to make a dummy type that delegates to the underlying type
handle, but provides an implementation for #getUnderlyingResource - to reutrn
the project that the scrapbook is in. (the BP marker will be associated with
the proejct that way - must have a resource for which to create marker on).
Comment 1 Darin Wright CLA 2001-10-23 12:20:04 EDT
Fixed.

Changed JavaLineBreakpoint.getResource(IType) to use the project resource for 
the type if the actual type does not exist as a resource. This simplifies the 
implemetnation (rather than making a dummy IType, which clients are not 
supposed to implement).

Re-assigning for verification.
Comment 2 Darin Wright CLA 2001-10-23 12:20:18 EDT
Please verify.
Comment 3 Jared Burns CLA 2001-11-12 12:06:48 EST
The refactoring looks good. 

However, there are still references to SnippetSupportLineBreakpoints in the XML.
They appear to be unused, but when I tried to remove them, my snippet
evaluations started failing.

Also, it's unclear if but 5715 is related to this change.
Comment 4 Darin Wright CLA 2001-11-12 12:41:52 EST
Removed plug-in XML for Scrapbook breakpoints. Verified scrapbook evaluation 
works as before (new java.util.Date()).

Comment 5 Darin Wright CLA 2001-11-12 12:42:08 EST
Re-open to re-assign
Comment 6 Darin Wright CLA 2001-11-12 12:42:27 EST
Re-assigning.
Comment 7 Darin Wright CLA 2001-11-12 12:42:38 EST
Please verify.
Comment 8 Jared Burns CLA 2001-11-13 10:42:52 EST
There is still a marker definition for snippetSupportLineBreakpoint in
org.eclipse.jdt.debug.plugin.xml. Is it there intentionally?
Comment 9 Darin Wright CLA 2001-11-13 10:49:43 EST
Removed reference. Re-tested and all is still good.
Comment 10 Jared Burns CLA 2001-11-13 11:18:03 EST
Verified. Looks good.