Bug 513794 - [Tooling] Resizing the state(-machine) frame in the superclass does not fully follow along in the subclass
Summary: [Tooling] Resizing the state(-machine) frame in the superclass does not fully...
Status: CLOSED FIXED
Alias: None
Product: Papyrus-rt
Classification: Modeling
Component: tool (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: 1.0.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-17 04:28 EDT by Peter Cigehn CLA
Modified: 2017-04-20 18:23 EDT (History)
2 users (show)

See Also:


Attachments
Screen shot showing a resized state frame in the subclass (17.21 KB, image/png)
2017-03-17 04:28 EDT, Peter Cigehn CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Cigehn CLA 2017-03-17 04:28:03 EDT
Created attachment 267306 [details]
Screen shot showing a resized state frame in the subclass

If you resize the state(-machine) frame in the superclass, does not cause the subclass to fully follow along, even if it follows the superclass view.

It seem to be some issue with the contained "region" (I have heard something about "zones" as well), which still has it's original issue. This in its turn causes issues with scroll-bars and elements that can get "lost" due to that they do not fit in the "region". The actual frame itself seem to follow along.

In the attached screen shot it can be seen that the "region" contained in the frame has not followed along and been resize to the same size as the frame itself. This can cause additional issues with scroll-bars (for example as discussed in Bug 507449).
Comment 1 Eclipse Genie CLA 2017-04-19 16:35:52 EDT
New Gerrit change created: https://git.eclipse.org/r/95325
Comment 3 Christian Damus CLA 2017-04-19 20:07:49 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/95325 was merged to [master].

There remain a couple of problems in the nested diagrams for composite states that is unrelated, or at least orthogonal, to this issue of following the superclass layout.  These should be tracked as separate bugs, probably in Papyrus.

1) For some reason, when redoing a change in the size of the diagram frame that was undone, the "zone" machinery in the base Papyrus edit-parts adds to the width of the RegionEditPart the difference between its previous width and its new width, even if the change that was undone (and then redone) was a shrinking of that width.

2) In the nested diagram for a state only, it seems that the name label causes the first reduction of the width of a RegionEditPart to be countermanded by the name label wanting to maintain the original width.  But then subsequent resize gestures of the diagram frame modify the region bounds as expected.
Comment 4 Peter Cigehn CLA 2017-04-20 04:25:37 EDT
Verified to be fixed in the latest Papyrus-RT build (#574). The state(-machine) frame now follow along in the subclass as expected.

Regarding the remaining issues mentioned in Comment 3, do you write bugs for tracking those (I guess as pairs of one tracking bug on the Papyrus-RT side, and another one for Papyrus)? I don't have enough insight to be able to formulate those.

Setting this one as verified fixed.
Comment 5 Peter Cigehn CLA 2017-04-20 04:25:52 EDT
Closing as verified fixed.
Comment 6 Christian Damus CLA 2017-04-20 14:07:15 EDT
(In reply to Peter Cigehn from comment #4)
> 
> Regarding the remaining issues mentioned in Comment 3, do you write bugs for
> tracking those (I guess as pairs of one tracking bug on the Papyrus-RT side,
> and another one for Papyrus)? I don't have enough insight to be able to
> formulate those.

No problem.  They are truly minor and bizarre details.  I have raised bug 515538 and bug 515540 for these issues.