Community
Participate
Working Groups
The context menu entries for breakpoint are not consequent. If the breakpoint is not set, there is an enabled "Toggle Breakpoint" and a disabled "Disable Breakpoint". If the breakpoint is set, there is an enabled "Toggle Breakpoint" and an enabled "Disable Breakpoint". If the breakpoint marker i not visible (e.g. because a warning in this line) it is quite complicated to think 'Ok, the "Disabled Breakpoint" entry is disabled, that means, if I want to enable the breakpoint I need to click "Toggle Breakpoint".' Suggestion: If no breakpoint is set change the menu item to an enabled "Enable Breakpoint".
Not sure, we can do it as people already using it will be confused.
Suggest to close as wont fix.
(In reply to Bernhard Maehr from comment #0) > Suggestion: If no breakpoint is set change the menu item to an enabled > "Enable Breakpoint". This will be more confusing, because user will see two differently named menu entries doing same thing. But what about: if NO breakpoint is set do NOT show "Disable breakpoint" menu at all? This would require refactoring: the <action> contribution with the id=org.eclipse.jdt.debug.ui.actions.EnableDisableBreakpointRulerActionDelegate should be moved from org.eclipse.ui.popupMenus extension point to org.eclipse.ui.menus and define the visibleWhen condition.
(In reply to Andrey Loskutov from comment #3) > (In reply to Bernhard Maehr from comment #0) > > Suggestion: If no breakpoint is set change the menu item to an enabled > > "Enable Breakpoint". > > This will be more confusing, because user will see two differently named > menu entries doing same thing. > > But what about: if NO breakpoint is set do NOT show "Disable breakpoint" > menu at all? > > This would require refactoring: the <action> contribution with the > id=org.eclipse.jdt.debug.ui.actions.EnableDisableBreakpointRulerActionDelegate > should be moved from org.eclipse.ui.popupMenus extension point to > org.eclipse.ui.menus and define the visibleWhen condition. Note that the menus differ whether Debug is loaded or not.
(In reply to Dani Megert from comment #4) > Note that the menus differ whether Debug is loaded or not. What do you mean by that? If the debugger is running or not, or if the debug plugins are loaded or not? And which difference is there? I couldn't find any differences in the ruler menu.
(In reply to Andrey Loskutov from comment #5) > (In reply to Dani Megert from comment #4) > > Note that the menus differ whether Debug is loaded or not. > > What do you mean by that? If the debugger is running or not, or if the debug > plugins are loaded or not? The latter. > And which difference is there? I couldn't find > any differences in the ruler menu. We don't load Debug when we open an editor. So, for example you won't see whether a breakpoint is enabled or not. Only when Debug is loaded it will show the real state. In the same line some menu items might be enabled even though not really applicable.
