Bug 51363 - Wrong comment positions inside the Scanner.
Summary: Wrong comment positions inside the Scanner.
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-02-09 10:25 EST by Olivier Thomann CLA
Modified: 2004-02-11 12:13 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-02-09 10:25:07 EST 
Using latest JDT/Core code, the end positions for a line comment is located
between the \r and the \n.
The DOM positions are ok, but I think the length for a DOM block comment is one
caracter too far.
Comment 1 Frederic Fusier CLA 2004-02-09 12:05:16 EST 
Fixed.

Now line comments include trailing '\r' and/or '\n'. This was an unnecessary 
change while fixing bug 51104. Put back previous behavior to avoid side effects 
in M7...

[jdt-core-dev internal]
Change back in getNextToken() and jumpOverMethodBody() methods in Scanner: 
recordComment(boolean) is called after having consumed '\r' and eventually '\r' 
characters. Also put back previous recordComments which was not working for 
unicode characters.

Test case added in jdt.core.tests.dom.ASTConverterJavadocTest.
Need to be completed with specific tests with unicode characters...
Comment 2 David Audel CLA 2004-02-11 12:13:47 EST 
Verfified for 3.0M7