Community
Participate
Working Groups
Steps: 1. open astManager.js (in the orion.client code) 2. the project context is computed as the orion.client folder (GOOD) 3. now open server.js in the orionode folder 4. the tools still thinks the project context is the orion.client folder because it is a sub-folder within the same project This behaviour is by design - we don't want to be computing the project every time we change files (possible performance issues), but we do have to support navigating into sub-projects (making sure we in fact switch contexts).
Created attachment 267234 [details] proposed fix This allows the tools to reset when navigating into a sub-project
Works for the prescribed steps, +1 for 14.0.
Pushed fix to: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8d4a600d3e1d130fde7864f837eb22e443901b0c I'm going to leave this open until we can spend time testing a deployed version to ensure there are no performance issues.
As I feared, if you navigate around a lot of files the tools get laggy - we cannot simply ask for the project every time we open a file. I reverted the fix for 14.0, we cannot introduce a performance regression. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ffe2aa932ed4be8e7e287733015e02930b7be311
(In reply to Michael Rennie from comment #4) > As I feared, if you navigate around a lot of files the tools get laggy - we > cannot simply ask for the project every time we open a file. > > I reverted the fix for 14.0, we cannot introduce a performance regression. > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/ > ?id=ffe2aa932ed4be8e7e287733015e02930b7be311 No matter what I have tried the performance remains bad having to re-resolve the project constantly.
I believe you but I find it incredible. On every mouse click, you go up the file tree doing an ls on each level, looking for files that have a certain name/pattern. I could understand if you a billion levels deep in the tree. Ok, let's defer this. It mean that "project anywhere" won't work.
(In reply to Steve Northover from comment #6) > I believe you but I find it incredible. On every mouse click, you go up the > file tree doing an ls on each level, looking for files that have a certain > name/pattern. I could understand if you a billion levels deep in the tree. > > Ok, let's defer this. It mean that "project anywhere" won't work. Project anywhere works fine - its project inside another project that does not work correctly - and it only "fails" when you have loaded the enclosing project context first.
I'd like to understand the cases where it fails and works and ensure that there is no intermittent behaviour. In general, I would prefer that a limited set of cases work every time rather than things work sometime.
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04114.html
