Bug 513012 - Can't see default text in dark themes (and git reset active branch) broken
Summary: Can't see default text in dark themes (and git reset active branch) broken
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 15.0   Edit
Assignee: Moshe WAJNBERG CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 512972 513103 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-02 15:48 EST by Carolyn MacLeod CLA
Modified: 2017-03-29 13:21 EDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2017-03-02 15:48:22 EST 
The fix for Bug 502409 - Bidi: Wrong display of server path containing bidi chars
broke dark themes in the editor.

On line 41 of pages.css, please do not use div[contenteditable="true"] because it affects all contenteditables in Orion, including the editor. In particular, it makes default text very difficult to see on a dark background theme because suddenly the default text color in the editor is #333 which is dark.

Please create a class name for the particular contenteditable that you wish to style, and use the .classname selector instead of the div[contenteditable="true"] attribute selector.
Comment 1 Silenio Quarti CLA 2017-03-04 09:48:49 EST 
This patch also cause an exception on the Git Page when reset branches.  Steps:

1) Open the git page
2) Select a commit
3) Click the "Reset your active branch...) command
4) Click OK button in the dialog

Uncaught TypeError: Cannot read property 'trim' of undefined
    at isValid (http://localhost:8082/orion/parameterCollectors.js:143:52)
    at Array.some (native)
    at CommandParameterCollector._collectAndCall (http://localhost:8082/orion/parameterCollectors.js:162:35)
    at finish (http://localhost:8082/orion/parameterCollectors.js:327:20)
    at HTMLButtonElement.<anonymous> (http://localhost:8082/orion/parameterCollectors.js:344:6)


I have revert the commit to address these issues.

http://git.eclipse.org/c/gerrit/orion/org.eclipse.orion.client.git/commit/?id=4654542438498510ea301140283110ae767bae56
Comment 2 Eclipse Genie CLA 2017-03-05 06:46:07 EST 
New Gerrit change created: https://git.eclipse.org/r/92317
Comment 3 Silenio Quarti CLA 2017-03-06 10:39:50 EST 
*** Bug 513103 has been marked as a duplicate of this bug. ***
Comment 4 libing wang CLA 2017-03-22 12:11:28 EDT 
This is the improved fix for bug 502409.
Comment 6 Carolyn MacLeod CLA 2017-03-28 10:41:34 EDT 
Libing, was this code committed? Does it fix both issues? If so, this bug can be closed.
Comment 7 Carolyn MacLeod CLA 2017-03-29 12:15:20 EDT 
Talked to Libing. He says both issues are fixed with the latest patch and it has been committed. Closing this bug.
Comment 8 Curtis Windatt CLA 2017-03-29 13:21:56 EDT 
*** Bug 512972 has been marked as a duplicate of this bug. ***