Bug 512424 - Validation is not done in the context of the VM that is being used to launch.
Summary: Validation is not done in the context of the VM that is being used to launch.
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
: 512599 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-20 08:07 EST by Nobody - feel free to take it CLA
Modified: 2022-07-28 01:55 EDT (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2017-02-20 08:07:43 EST
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=467028#c27 and https://bugs.eclipse.org/bugs/show_bug.cgi?id=467028#c26 for detailed explanation and screenshot of the issue.
Comment 1 Nobody - feel free to take it CLA 2017-02-21 09:38:23 EST
An additional comment here is that you have to check the checkbox labelled "Validate Plug-ins automatically prior to launching" to see this prior to launch. Otherwise you have to validate automatically.
Comment 2 Nobody - feel free to take it CLA 2017-02-21 09:38:55 EST
(In reply to Sopot Cela from comment #1)
> Otherwise you have to validate automatically.

I meant manually not automatically.
Comment 3 Markus Keller CLA 2017-02-21 15:09:18 EST
(In reply to Sopot Cela from comment #1)
> An additional comment here is that you have to check the checkbox labelled
> "Validate Plug-ins automatically prior to launching" to see this prior to
> launch.

Filed bug 512528 for the incomplete hack from bug 272076.


Steps in I20170220-2000:

- import bundles/org.eclipse.equinox.registry from master of git://git.eclipse.org/gitroot/equinox/rt.equinox.bundles.git
- fix API baseline (set to 4.6.2)

=> API Tools reports an "Unknown Resolution Problem":
API analysis aborted: org.eclipse.equinox.registry has unresolved constraints: javax.xml.parsers 0.0.0, org.xml.sax 0.0.0, org.xml.sax.helpers 0.0.0

- launch validation reports the same problems


The problems are legitimate. CDC-1.1/Foundation-1.1 doesn't include the mentioned packages, so after bug 467028, these imports are indeed unresolvable.

Moving this bug to Equinox.

The easiest fix is to reduce the BREE to
Bundle-RequiredExecutionEnvironment: J2SE-1.4
Comment 4 Thomas Watson CLA 2017-02-21 16:42:10 EST
(In reply to Markus Keller from comment #3)
> Moving this bug to Equinox.
> 
> The easiest fix is to reduce the BREE to
> Bundle-RequiredExecutionEnvironment: J2SE-1.4

Thanks, I agree with this and will make the update.  At some point I think the registry should be updated to something more recent for the BREE, even to Java 8.  But I will not do that for this issue.
Comment 5 Eclipse Genie CLA 2017-02-22 08:44:55 EST
New Gerrit change created: https://git.eclipse.org/r/91615
Comment 7 Thomas Watson CLA 2017-02-22 09:10:48 EST
(In reply to Markus Keller from comment #3)
> The problems are legitimate. CDC-1.1/Foundation-1.1 doesn't include the
> mentioned packages, so after bug 467028, these imports are indeed
> unresolvable.

Something is still wrong with this validation.  The context that PDE should be resolving the set of bundles should be the VM that it is going to launch with.  That VM is going to contain the javax.xml packages (unless you are running on something less than Java 1.4).  The registry bundle imports the javax.xml packages, it should not care if that comes from a bundle or the VM for validation purposes.

I don't see the value of forcing a javax.xml bundle in this case where the BREE may specify an EE that does not have the package, but you are launching with one that does have the package.

(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/91615 was merged to [master].
> Commit:
> http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/
> ?id=19b35a118a3ed727f414ba14c23412b403eb6daa

Regardless of the issue in PDE, I did update the registry to remove the Foundation-1.1 support.

Moving back to PDE for discussion or closure.
Comment 8 Markus Keller CLA 2017-02-22 09:30:26 EST
(In reply to Thomas Watson from comment #7)
> Something is still wrong with this validation.  The context that PDE should
> be resolving the set of bundles should be the VM that it is going to launch
> with.

Good point. Pre-launch validation should use the actual VM.
API Tools can't know the actual VM, so the API Tools problem is OK.
Comment 9 Thomas Watson CLA 2017-02-23 08:48:18 EST
*** Bug 512599 has been marked as a duplicate of this bug. ***
Comment 10 Casey Lowe CLA 2017-10-10 17:16:15 EDT
Is there any update on this issue or time-frame for resolution? Thanks
Comment 11 Eclipse Genie CLA 2020-08-06 15:53:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 12 Eclipse Genie CLA 2022-07-28 01:55:11 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.