Bug 512335 - [formatter] UI for new feature: count comment width from starting position
Summary: [formatter] UI for new feature: count comment width from starting position
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 M6   Edit
Assignee: Mateusz Matela CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2017-02-16 18:50 EST by Mateusz Matela CLA
Modified: 2017-03-09 04:59 EST (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Matela CLA 2017-02-16 18:50:17 EST 
Following up bug 362260, we need to add a new checkbox in formatter profile editor.
I'll push to gerrit tomorrow when nightly build including the new feature is hopefully ready.
Comment 1 Eclipse Genie CLA 2017-02-17 10:51:58 EST 
New Gerrit change created: https://git.eclipse.org/r/91388
Comment 3 Dani Megert CLA 2017-02-20 04:03:07 EST 
Thanks  Mateusz.

Please add this to the New & Noteworthy.
Comment 4 Dani Megert CLA 2017-03-08 09:42:43 EST 
(In reply to Dani Megert from comment #3)
> Thanks  Mateusz.
> 
> Please add this to the New & Noteworthy.

Ping! M6 is this Friday.
Comment 5 Mateusz Matela CLA 2017-03-08 18:08:07 EST 
Added to the New & Noteworthy with http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3fb52bb71d57a1c156a317f93a4ed2262fb9212e

Sorry for the delay, I was hoping we would take care of bug 362260 comment 9 (default value for the new setting) and it would affect the n&n note's content.
Comment 6 Dani Megert CLA 2017-03-09 04:59:16 EST 
(In reply to Mateusz Matela from comment #5)
> Added to the New & Noteworthy with
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3fb52bb71d57a1c156a317f93a4ed2262fb9212e
> 
> 
> Sorry for the delay, I was hoping we would take care of bug 362260 comment 9
> (default value for the new setting) and it would affect the n&n note's
> content.

My bad. That comment got lost in my haystack. I like the idea.