Bug 512329 - Chore: AbstractPublishApplicationOperation has two methods to fetch modules
Summary: Chore: AbstractPublishApplicationOperation has two methods to fetch modules
Status: RESOLVED FIXED
Alias: None
Product: CFT
Classification: ECD
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal
Target Milestone: 1.1.0 M7   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2017-02-16 15:20 EST by Nieraj Singh CLA
Modified: 2017-05-19 14:30 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nieraj Singh CLA 2017-02-16 15:20:37 EST 
AbstractPublishApplicationOperation has two separate methods to return a module:

getModule()
getModules()

They both return the same module, except one is an array. Since publish operations only work on the root module in an array of modules, consider removing one of these two methods and just using one to avoid confusion which one to use.
Comment 1 Nieraj Singh CLA 2017-05-19 14:30:01 EDT 
This has already been "fixed". There are still two methods to fetch modules in the operation: all the modules, or the first module. The API change now reflects this.