Bug 511234 - [dark theme] Overlay icons look not very well on dark theme
Summary: [dark theme] Overlay icons look not very well on dark theme
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows NT
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
: 563679 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-27 14:00 EST by Ralf Petter CLA
Modified: 2022-05-28 18:34 EDT (History)
6 users (show)

See Also:

Attachments
Screenshot of package explorer overlay icons in themes with white and dark background (195.97 KB, image/png)
2017-01-27 14:00 EST, Ralf Petter CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Petter CLA 2017-01-27 14:00:58 EST 
Created attachment 266498 [details]
Screenshot of package explorer overlay icons in themes with white and dark background

The overlay icons in JDT have only fake transparency which works only well on white backgrounds, so that all overlay icons in package explorer and the outline looks wrong when the developer is using the dark theme. Have a look at the attached screenshot for an example how it looks in oxygen and how it should look in my opinion.
Comment 1 Ralf Petter CLA 2017-01-27 14:03:33 EST 
I will push a reworked icon set to gerrit.
Comment 2 Eclipse Genie CLA 2017-01-27 14:06:38 EST 
New Gerrit change created: https://git.eclipse.org/r/89771
Comment 3 Lars Vogel CLA 2017-01-30 10:56:39 EST 
(In reply to Eclipse Genie from comment #2)
> New Gerrit change created: https://git.eclipse.org/r/89771

We also need a change for our images repository. See https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.images
Comment 4 Ralf Petter CLA 2017-01-30 11:52:49 EST 
Okay did not know, that the icons are generated out of svg images. I will  install the image repository and try to update one of the svg images.
Comment 5 Lars Vogel CLA 2017-02-13 12:02:02 EST 
(In reply to Ralf Petter from comment #4)
> Okay did not know, that the icons are generated out of svg images. I will 
> install the image repository and try to update one of the svg images.

Any update Ralf with the svg update?
Comment 6 Ralf Petter CLA 2017-02-13 12:34:43 EST 
Sorry Lars. I have been very ill for the last 3 Weeks. I am in the hospital in the moment. I have no idea, when i can work again
Comment 7 Lars Vogel CLA 2017-02-13 12:42:57 EST 
(In reply to Ralf Petter from comment #6)
> Sorry Lars.

All the best to you.
Comment 8 Markus Keller CLA 2017-02-28 12:56:41 EST 
Note that the white borders in some overlay images are not just "fake transparency". The overlays need some border to ensure they're perceived as _over_lays and not as a part of the underlying image.

Especially check:
- the "abstract" adornment on a public method, e.g. java.util.Iterator#next()
- cases with multiple adornments, e.g. children of java.util.HashMap or Locale
Comment 9 Alex Blewitt CLA 2020-05-28 11:18:49 EDT 
*** Bug 563679 has been marked as a duplicate of this bug. ***
Comment 10 Eclipse Genie CLA 2022-05-28 18:34:14 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.