Bug 511112 - Avoid probing searches for package.json files if the project has no node_modules folder
Summary: Avoid probing searches for package.json files if the project has no node_modu...
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: 13.0   Edit
Hardware: PC Mac OS X
: P2 normal (vote)
Target Milestone: 14.0   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2017-01-26 12:07 EST by Michael Rennie CLA
Modified: 2017-01-26 15:11 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2017-01-26 12:07:32 EST 
Currently, when working in a node project, we have special code that will crawl for package.json files for required libraries. The problem is that we do this search even if the project you are working in does not have a node_modules folder.

We need to add support to avoid doing any of these lookups if there is no node_modules folder.
Comment 1 Michael Rennie CLA 2017-01-26 14:17:36 EST 
Spurious searches fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=652c362f4d9e60bcdf43910ec32096d7afdbfda0

Only part remaining is to ensure that if someone does add a node_modules folder, that we reset the project flags to start searching in it.
Comment 2 Michael Rennie CLA 2017-01-26 15:11:12 EST 
Support for handling changes to node_modules:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d57fd5a7837bfcb902db8e9a60534a61417aad56