Community
Participate
Working Groups
Created attachment 266432 [details] Where to make it available It would help me a lot in injecting the list of changed files into our internal documentation system. 'Select all' is already there. Would be nice to be able to copy.
+1, maybe you want to contribute this ? Find the contributor guide here https://wiki.eclipse.org/EGit/Contributor_Guide
(In reply to Matthias Sohn from comment #1) > +1, maybe you want to contribute this ? > > Find the contributor guide here > https://wiki.eclipse.org/EGit/Contributor_Guide yes, I'll give it a try.
(In reply to Philippe Brossel from comment #2) > yes, I'll give it a try. Any update here Philippe?
Sorry, didn't have the time up to now. I'll dive into it during next summer holiday.
(In reply to Philippe Brossel from comment #4) > Sorry, didn't have the time up to now. > I'll dive into it during next summer holiday. Fabian, please have a look if you can fix that. This is really annoying.
Lars, can you explain what you mean by 'annoying' ? Remember I opened the bug to learn how to contribute to projects not to lose anyone's time. The expected function will probably not be of any interest to anyone but me. So either close the bug without losing more time if it is hindering or let it open for just me to get started with contributing. In this case I will 'fix it' in august this year.
(In reply to Philippe Brossel from comment #6) > Lars, can you explain what you mean by 'annoying' ? Sorry, this was indeed unclear. Let me try to clarify: I find it annoying that copy and paste does not work in Git Staging view. The last weeks I had to copy the file names which I committed and this missing feature was super annoying. This was not at all a statement about you, again sorry in case that was unclear. And I hope that Fabian has time to contribute this within the next days, hence I asked him to have a look at this issue. Thanks for reporting and I'm sure if Fabian solves this, you will find another issue to contribute to.
OK, understood. So now we're at least 2 guys interested in this new feature. Just kidding ...
New Gerrit change created: https://git.eclipse.org/r/98589
I've added a gerrit but it's still WIP. I'm not sure I'm taking the right approach in the implementation but it works. Do you think the full file path or only the file name should be copied? I think there can be made a case for both options.
(In reply to Fabian Pfaff from comment #10) > Do you think the full file path or only the file name should be copied? I suggest to copy only the file name.
Would this not be confusing when having the same filename at different hierachy levels ? (e.g 'plugin.xml'). I would personaly prefer something like the eclipse context menu option 'Copy qualified name', yielding e.g. '/com.eupen.test.pluginThree/src/com/eupen/test/pluginThree/export/EPluginThreePublicClassOne.java' for the class 'EPluginThreePublicClassOne'.
(In reply to Philippe Brossel from comment #12) > Would this not be confusing when having the same filename at different > hierachy levels ? (e.g 'plugin.xml'). > > I would personaly prefer something like the eclipse context menu option > 'Copy qualified name', yielding e.g. > '/com.eupen.test.pluginThree/src/com/eupen/test/pluginThree/export/ > EPluginThreePublicClassOne.java' for the class 'EPluginThreePublicClassOne'. Also fine for me.
(In reply to Lars Vogel from comment #13) > Also fine for me. I frequently need only the file name as displayed (not the full qualified name), e.g., for the commit message. @Fabian, if you provide a patch, please use this as the first version. We or Philippe may extend this later, e.g., with a shift +copy+c copy.
(In reply to Lars Vogel from comment #14) > (In reply to Lars Vogel from comment #13) > > Also fine for me. > > I frequently need only the file name as displayed (not the full qualified > name), e.g., for the commit message. @Fabian, if you provide a patch, please > use this as the first version. We or Philippe may extend this later, e.g., > with a shift +copy+c copy. Try content assist for filenames of files which are staged for the commit. This was implemented a long time back. Type the first few characters of the file name of a file which is staged for the commit and then click CTRL-spacebar to experience the magic of content assist :-)
(In reply to Matthias Sohn from comment #15) > Try content assist for filenames of files which are staged for the commit. > This was implemented a long time back. Cool feature, thanks for notifying. I primarily use the tree representation. Would be nice if the tree nodes could be added to the content assists. I open a separate bug for that.
(In reply to Lars Vogel from comment #16) > I open a separate bug for that. Bug 519660.
(In reply to Lars Vogel from comment #14) > (In reply to Lars Vogel from comment #13) > > Also fine for me. > > I frequently need only the file name as displayed (not the full qualified > name), e.g., for the commit message. @Fabian, if you provide a patch, please > use this as the first version. We or Philippe may extend this later, e.g., > with a shift +copy+c copy. Any update ? Can I help to finalize Fabian's work ?
(In reply to Philippe Brossel from comment #18) > (In reply to Lars Vogel from comment #14) > > (In reply to Lars Vogel from comment #13) > > > Also fine for me. > > > > I frequently need only the file name as displayed (not the full qualified > > name), e.g., for the commit message. @Fabian, if you provide a patch, please > > use this as the first version. We or Philippe may extend this later, e.g., > > with a shift +copy+c copy. > > Any update ? there was no update on https://git.eclipse.org/r/#/c/98589/ since June 3 and there are a number of comments on this patch which need to be fixed > Can I help to finalize Fabian's work ? sure
Gerrit change https://git.eclipse.org/r/98589 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=14652472b2aa7901279a01d76cc1b6dff3fa8207
