Community
Participate
Working Groups
It would be nice to see some checkbox 'final' in New C++ Class which generates 'final' class which denies inheritance in c++11. Small and sweet feature.
New Gerrit change created: https://git.eclipse.org/r/157025
Gerrit change https://git.eclipse.org/r/157025 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=ccabaa21186315d47323d8c077b7b886c70aa14a
Hi Marco, Thank you for the fix. There is a little cleanup needed as the change introduces API changes that imply a major version bump. I have reopened the bug as it needs resolving before the release. Errors: The major version should be incremented in version 6.7.0, since API breakage occurred since version 6.6.100 The constant value 255 of the field org.eclipse.cdt.ui.wizards.NewClassCreationWizardPage.ALL_FIELDS has been changed The field org.eclipse.cdt.ui.wizards.NewClassCreationWizardPage.FINAL_ID has been added to a class The field org.eclipse.cdt.ui.wizards.NewClassCreationWizardPage.fIsFinalClassField has been added to a class The field org.eclipse.cdt.ui.wizards.NewClassCreationWizardPage.fIsFinalStatus has been added to a class
Do we need 7.0.0?
(In reply to Marco Stornelli from comment #4) > Do we need 7.0.0? No, we can't bump the major version now as that needs notifcation ahead of time. We may be able to bump it for 2020-06 release in June though.
I'm a bit confused then, what's the short term action needed now?
Your change has broken API, so you need to rework it to not require a major version bump, or add API filters if this is not real API and just API leaking. However, you are in CDT core the bar is pretty high for just doing a filter.
PS, do you see the errors in your workspace? If not, you need to check your api baseline is set up.
At the moment I can't see how I could modify it to avoid the modification of ALL_FIELDS or how I could avoid to use additional fields. Tomorrow I will take a look. If there's no way, since it's an enhancement, we could revert the change and insert the modification in 2020-06.
New Gerrit change created: https://git.eclipse.org/r/157735
(In reply to Eclipse Genie from comment #10) > New Gerrit change created: https://git.eclipse.org/r/157735 This is an example that makes it API compatible at the Java API level. Note that cases like this are nearly impossible to know how to change because the original code did not document the API and how it was intended to be extended. So the change I provided makes the code not generate runtime class loading/method invocation errors, but that is it.
New Gerrit change created: https://git.eclipse.org/r/157749
Gerrit change https://git.eclipse.org/r/157749 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=757eab43071db8d3ed0f68ce94c46b01f4258e3c
This bug had been targeted at CDT 9.12.0 and is now targeted at CDT 10.0.0. Following announcement on cdt-dev[1] CDT 9.12.0 is no longer being released and instead CDT 10.0.0 will be released in September and CDT 9.11.1 in June. If this bug/fix needs to be released as soon as possible, please cherry-pick to the CDT 9.11 branch and update the target milestone. [1] https://www.eclipse.org/lists/cdt-dev/msg34317.html
New Gerrit change created: https://git.eclipse.org/r/160468
Gerrit change https://git.eclipse.org/r/160468 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=31b748e7b9ce00dd4e5286f4a12236f263e3ec5f
