Bug 510646 - Completed operations don't actually get removed by operationsClient
Summary: Completed operations don't actually get removed by operationsClient
Status: REOPENED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Node (show other bugs)
Version: 13.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 18.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, triaged
Depends on:
Blocks:
 
Reported: 2017-01-18 14:04 EST by Michael Rennie CLA
Modified: 2018-02-01 10:10 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2017-01-18 14:04:02 EST
Perhaps some fallout from the fix for bug 507934, but now if you go to the tasks view with the developer tools open, you will see a pile of 404 entries like:

xhr.js:175 GET http://localhost:8081/task/id/beb0ff04391484765865813 404 (Not Found)

Steps:
1. start Orion, head to the git page (for any repo)
2. open the dev tools in browser or electron
3. from the git page, head over to the All Operations view
4. check the log
Comment 1 Remy Suen CLA 2017-01-18 15:38:33 EST
I commented out the username check and it still seems to happen so I'm not sure if this bug is caused by the fix for bug 507934.

On the other hand, if it really was caused by the fix then that would imply that the client is (and has been) sending GETs and DELETEs to other user's tasks. Uh... o_o
Comment 2 Steve Northover CLA 2017-03-30 17:00:22 EDT
Is this still happening?  Is sounds bad but we have been living with it for a while now.  What is the exact failure the user will see?
Comment 3 Michael Rennie CLA 2017-03-31 10:37:59 EDT
(In reply to Steve Northover from comment #2)
> Is this still happening?  Is sounds bad but we have been living with it for
> a while now.  What is the exact failure the user will see?

Yes, this still happens. It also happens online as well (the original bug was filed against local development). 

If the user happened to open the dev tools, they would see hundreds of 404s - which makes me think we are making a tonne of requests that should be avoided (since they all 404).
Comment 4 Grant Gayed CLA 2017-04-03 10:55:21 EDT
I don't see this, tried at orion.eclipse.org, and locally with both the memory-based and mongo-based storages.  On the Git page I cloned some repos and did some Syncs.  Is it possible that the steps to make this happen are not as general as the comment 0 steps imply?
Comment 5 Michael Rennie CLA 2017-04-03 13:29:56 EDT
(In reply to Grant Gayed from comment #4)
> I don't see this, tried at orion.eclipse.org, and locally with both the
> memory-based and mongo-based storages.  On the Git page I cloned some repos
> and did some Syncs.  Is it possible that the steps to make this happen are
> not as general as the comment 0 steps imply?

The steps still work for me 100% of the time.

I have cleared localStorage, cookies, etc, and it still happens.
Comment 6 Steve Northover CLA 2017-04-13 14:54:44 EDT
Remy, did you want to take a look at this one?
Comment 7 Remy Suen CLA 2017-04-13 18:26:34 EDT
(In reply to Steve Northover from comment #6)
> Remy, did you want to take a look at this one?

I looked a bit at this just now but didn't get anywhere. Unfortunately, I can't reproduce it anymore though I'm not sure why as I'm pretty sure we didn't change any code in this area.
Comment 8 Steve Northover CLA 2017-04-17 10:40:14 EDT
Nobody sees the except Mike.  Mike, can you help other recreate it?
Comment 9 Michael Rennie CLA 2017-04-24 12:46:24 EDT
(In reply to Remy Suen from comment #7)
> (In reply to Steve Northover from comment #6)
> > Remy, did you want to take a look at this one?
> 
> I looked a bit at this just now but didn't get anywhere. Unfortunately, I
> can't reproduce it anymore though I'm not sure why as I'm pretty sure we
> didn't change any code in this area.

I just tried again, using the original steps and trying to perform a bunch of operations on a bunch of repos, and can no longer reproduce. Doesn't make sense since (as Remy noted) we haven't changed code in this area.

I'll close this since it doesn't seem to happen anymore. I'll reopen if I get it to happen again.
Comment 10 Michael Rennie CLA 2017-04-28 16:20:53 EDT
Managed to reproduce again:

1. on orion.eclipse.org
2. open git view on orion.client
3. wait until fetching done
4. open console
5. go to task log view (view all tasks) (ok, no exceptions like before)
6. hit 'Remove Completed'
7. get the following:

orionPlugin.js:1 GET https://orion.eclipse.org/task/id/08823340201493410517442 404 (Not Found)
Comment 11 Remy Suen CLA 2017-05-01 06:08:15 EDT
(In reply to Michael Rennie from comment #10)
> Managed to reproduce again:
> 
> 1. on orion.eclipse.org
> 2. open git view on orion.client
> 3. wait until fetching done
> 4. open console
> 5. go to task log view (view all tasks) (ok, no exceptions like before)
> 6. hit 'Remove Completed'
> 7. get the following:
> 
> orionPlugin.js:1 GET
> https://orion.eclipse.org/task/id/08823340201493410517442 404 (Not Found)

I get this error but I don't think this is the same issue as what was originally reported. Regardless, I'll take a gander here...
Comment 12 Remy Suen CLA 2017-05-02 05:23:58 EDT
(In reply to Remy Suen from comment #11)
> I get this error but I don't think this is the same issue as what was
> originally reported.

Based on the fix I'm not sure if it's really related to the original problem in comment 0. In any case, I've pushed a pull request up for review.

https://github.com/eclipse/orion.client/pull/14

The test isn't failing for whatever reasons. Could someone take a look, please? Thanks! :)
Comment 13 Steve Northover CLA 2017-05-02 08:14:05 EDT
Grant, can you look at this?
Comment 14 Steve Northover CLA 2017-09-22 14:36:39 EDT
Grant, Michael ... still happening?