Community
Participate
Working Groups
This bug will track Bug 506718
I have a feeling that this bug contains too little information. What is it that we are tracking and why? In this specific case we already have made a work around in Bug 507744, so I assume what is meant is that the work-around introduced by Bug 507744 should be reverted, i.e. the resetting of the rounded bend points shall be removed. This one the other hand, could be discussed if that revert really shall be made or not. One benefit of keeping the "work around" is that the look-and-feel of the bend points are more aligned with how they look in Papyrus. I am not sure if there are any preference for controlling that new edges have rounded bend points or not (otherwise imported diagrams will have some rounded bend points for edges imported from legacy tooling, vs new edges that does not have rounded bend points). So before reverting the current "work around", this might need to be considered.
(In reply to Peter Cigehn from comment #1) > I have a feeling that this bug contains too little information. What is it > that we are tracking and why? I just follow Simon pattern to track papyrus bug (see Bug 510534 and Bug 510533) In this specific case we already have made a > work around in Bug 507744, so I assume what is meant is that the work-around > introduced by Bug 507744 should be reverted, i.e. the resetting of the > rounded bend points shall be removed. > > This one the other hand, could be discussed if that revert really shall be > made or not. One benefit of keeping the "work around" is that the > look-and-feel of the bend points are more aligned with how they look in > Papyrus. I am not sure if there are any preference for controlling that new > edges have rounded bend points or not (otherwise imported diagrams will have > some rounded bend points for edges imported from legacy tooling, vs new > edges that does not have rounded bend points). So before reverting the > current "work around", this might need to be considered. OK, if the fact that the papyrus imported model change the look of some edges (edges with roundedbendpoint in legcy model are not with roundedbendpoint in the imported model) did not bother end user, it is OK.
(In reply to smaoui asma from comment #2) > (In reply to Peter Cigehn from comment #1) > > I have a feeling that this bug contains too little information. What is it > > that we are tracking and why? > > I just follow Simon pattern to track papyrus bug (see Bug 510534 and Bug > 510533) Well, I can't say that those gives much information either. One of them, Bug 510533, as I indicated offline, should not have been needed to be written at all since we already have Bug 492356 tracking this aspect on the Papyrus-RT side. For the other one, Bug 510534, we are not tracking anything related to a work-around (which I assume this one is doing). So there don't need to be much information in such a tracking bug (everything needed is actually in the bug that it depends on). This bug on the other hand more follows the pattern of reverting an already earlier work-around, i.e. it is much more similar to Bug 510333 that Rémi wrote. So some background information in such a bug is probably needed to understand the context. > In this specific case we already have made a > > work around in Bug 507744, so I assume what is meant is that the work-around > > introduced by Bug 507744 should be reverted, i.e. the resetting of the > > rounded bend points shall be removed. > > > > This one the other hand, could be discussed if that revert really shall be > > made or not. One benefit of keeping the "work around" is that the > > look-and-feel of the bend points are more aligned with how they look in > > Papyrus. I am not sure if there are any preference for controlling that new > > edges have rounded bend points or not (otherwise imported diagrams will have > > some rounded bend points for edges imported from legacy tooling, vs new > > edges that does not have rounded bend points). So before reverting the > > current "work around", this might need to be considered. > > OK, if the fact that the papyrus imported model change the look of some > edges (edges with roundedbendpoint in legcy model are not with > roundedbendpoint in the imported model) did not bother end user, it is OK. It is more an issue that if the "old stuff" (being imported from the legacy tooling) does not look the same as the "new stuff" (being added in Papyrus/Papyrus-RT), then it is probably more acceptable to adjust the legacy information to be more aligned with how the new information will look like. As I said, I have not found any way of controlling whether bend points shall be round or not, e.g. using some preference. Maybe it is possible to control it via CSS, but it is exactly those kinds of aspects that probably should be considered if and when reverting the work around.
