Community
Participate
Working Groups
The commit [1], "[test] Fix broken condition check", tries to fix the broken condition "assertEquals(getDNodeResizeKind(dNodeEditPartBot), getDNodeResizeKind(dNodeEditPartBot));". Instead, it reveals that this test is wrongly written. Indeed, since the fix of commit [1], the test fails with "DNode.resizeKind should be equals to NONE expected:<NONE> but was:<NSEW>". The resize kind was never changed. When trying to fix it and really change the resize king with gerrit [2], I discovered that there is probably a regression since commit [3], "[481098] Sizing on node creation only on authorized resizing directions", about resize kind policy changes. As this is not just a "bug fix", this bugzilla has been created to analyse the problem. The gerrit [4] disables the tests corresponding to resize kind changes waiting the fix of this bugzilla. [1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3ce94d58bbb250e1c462f1d1c66c8607d16ecb64 [2] https://git.eclipse.org/r/88753 [3] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3dcfa218f627f916ab1ebb646a7a64091e7d162a [4] https://git.eclipse.org/r/88752
Depending on the result of the analysis and the impacts of a fix (if indeed there is a significant regression) we should consider backporting the fix to the 4.1.x branch.
Gerrit change https://git.eclipse.org/r/88753 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4aa5fad8f6feffebca0abb1a134aef10fd7d75bc
Gerrit change https://git.eclipse.org/r/88752 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4c498a17701d67d126e1951455103fbb5c82967f
(In reply to Laurent Redor from comment #0) > ...there is probably a regression since commit [3] ... Additional information: The method org.eclipse.sirius.diagram.ui.edit.internal.part.AbstractDiagramNodeEditPartRefreshVisualsOperation.refreshWidth() is an example
Moving to 5.1. Before the commit that revealed the issue, the test class in question had not been changed for at least 2 years. If indeed there is a regression, it has existed for years.
