Bug 510398 - Provide by default a dialog to preview the impact of a delete from model action
Summary: Provide by default a dialog to preview the impact of a delete from model action
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows NT
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-01-12 17:21 EST by Ed Willink CLA
Modified: 2017-03-22 06:39 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2017-01-12 17:21:58 EST
A Sirius Diagram is a View of a Model, therefore Delete should default to delete-from-view (diagram). Not delete from model.

Using the Delete key corrupts the model without a pop-up warning.

CRITICAL since this is a major inconsistency with the Industry norm, in particular with Papyrus.

---

The context menu offers multiple deletes with confusing short cuts to "d" not "Del".

The toolbar offers two deletes but no hover text to inform of which keys are equivalent.
Comment 1 Cedric Brun CLA 2017-01-13 02:38:17 EST
You realize it is not "corrupting the model" but deleting part of it, as the name suggest quite clearly. You also realize that CTRL-Z will bring you back to the previous state.

I guess the "Industry norm" is relative to the eye of the beholder, in any case we have tenth of thousands of users and years of being out in the wild (and I'm not even mentionning the pre-OSS era), there is no way we could adapt the behavior in the way you suggest.

That being said, today Sirius provides extension points and hooks to have some kind of "preview before delete" popup and this has been used in other products (Capella, UML Designer,...) having it directly in the core platform would be an interesting enhancement and would fix your use case.

I'm requalifying this bug based on this: that's as far as we can go to take your feedback in account while avoiding to alienate the existing users.
Comment 2 Ed Willink CLA 2017-01-13 04:43:56 EST
Puzzling. I thought I was re-inforcing a Forum message. But it was a Papyrus thread (https://www.eclipse.org/forums/index.php/mv/msg/1082732/1748656/#msg_1748656) where the same complaint was raised, and a Papyrus author recalled changing the bindings at least twice.

Puzzling, because from my comment on the thread, I must have checked that Sirius was sensible in order to recommend that Papyrus be the same as Sirius. Has the Sirius functionality changed recently?
Comment 3 Pierre-Charles David CLA 2017-01-17 07:16:27 EST
(In reply to Cedric Brun from comment #1)
> That being said, today Sirius provides extension points and hooks to have
> some kind of "preview before delete" popup and this has been used in other
> products (Capella, UML Designer,...)

For later reference, the implementations Cédric refers to can be found at:
* For UML Designer (https://github.com/ObeoNetwork/UML-Designer): plugins/org.obeonetwork.dsl.uml2.design/src/org/obeonetwork/dsl/uml2/design/internal/dialogs/ConfirmDeletionDialog.java
* For Capella (http://git.polarsys.org/c/capella/capella.git/): core/plugins/org.polarsys.capella.core.ui.toolkit/src/org/polarsys/capella/core/ui/toolkit/dialogs/ConfirmDeleteCapellaElementDialog.java
Comment 4 Cedric Brun CLA 2017-01-17 10:01:45 EST
> Has the Sirius functionality changed recently?

No, you can try UML Designer 3.0.0 [1] released in 2013 on top of " Obeo Designer 6.2" (even before Sirius existed in Eclipse) and you'll see the same behavior and shortcuts.

http://www.umldesigner.org/download/