Bug 510243 - Improve properties view toolbar actions
Summary: Improve properties view toolbar actions
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Properties (show other bugs)
Version: 4.1.1   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-01-11 05:19 EST by Stephane Begaudeau CLA
Modified: 2018-12-05 02:27 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephane Begaudeau CLA 2017-01-11 05:19:38 EST 
Add support for:
* tooltipExpression
* hoverImageExpression
* sub-actions
Comment 1 Axel RICHARD CLA 2017-01-11 05:41:49 EST 
The tooltipExpression is already handled by https://bugs.eclipse.org/bugs/show_bug.cgi?id=496076
Comment 2 Axel RICHARD CLA 2017-01-11 09:26:00 EST 
The hoverImageExpression can't be handled correctly.
Indeed, with the default implementation of org.eclipse.jface.action.ActionContributionItem, the private method boolean updateImage(boolean forceImage) if the hoverImageDescriptor is set, then it is taken as the image in place of the imageDescriptor.
See boolean org.eclipse.jface.action.ActionContributionItem.updateImages(boolean forceImage) fore more details.
Comment 3 Eclipse Genie CLA 2017-01-13 04:07:11 EST 
New Gerrit change created: https://git.eclipse.org/r/88617
Comment 4 Eclipse Genie CLA 2017-01-13 04:07:23 EST 
New Gerrit change created: https://git.eclipse.org/r/88618
Comment 5 Pierre-Charles David CLA 2017-03-22 04:35:34 EDT 
Moving to 5.1 as this is not essential for 5.0. If this is fixed for 5.0, fine, but it's not blocking for 5.0.