Bug 510044 - [Tracking] Rename no longer available in model explorer
Summary: [Tracking] Rename no longer available in model explorer
Status: CLOSED FIXED
Alias: None
Product: Papyrus-rt
Classification: Modeling
Component: tool (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Mac OS X
: P3 normal
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Peter Cigehn CLA
URL:
Whiteboard: depends_on_papyrus
Keywords: ui
Depends on: 509357 514322
Blocks:
  Show dependency tree
 
Reported: 2017-01-06 11:00 EST by Charles Rivet CLA
Modified: 2017-05-31 22:45 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Rivet CLA 2017-01-06 11:00:43 EST
Using Papyrus-RT 0.8.0.201701060934

Comment received via email from a user trying Papyrus-RT v0.8:

"The 'Rename' item seems to have disappeared from all context menus. Most of the renaming has to be done in the properties view."

Verified in Papyrus-RT 0.8.0.201701060934
Comment 1 Peter Cigehn CLA 2017-01-09 07:45:15 EST
I checked this in latest nightly build of base Papyrus, and the Rename menu item is not available there either. I guess that the missing menu choice is related to the new "inline editing" feature where rename the model element inline in the model explorer tree, instead of opening a model edit dialog as was done before. See Bug 492356 for this feature in Papyrus-RT and the related Bug 476629 and Bug 497289 in Papyrus.

Not fully sure though why the Rename menu choice was completely removed. On the other hand, the inline editing feature (depending on which model element it is) supports even more editing possibilities than just renaming the model element, and hence it would have been confusing to keep a menu choice explicitly named "Rename". In the legacy tooling the corresponding menu choice is named "Edit", which then activates the inline editing, a name which indicates its broader scope. If a menu choice is going to be re-introduced again then I would suggest to name it "Edit" to cover the broader scope that the inline editing provides.

What can be noted though is that the short-cut key F2 is still possible to use, even though the menu choice is not available anymore, i.e. pressing F2 activates the inline editing of the model element so that it can be renamed.
Comment 2 Charles Rivet CLA 2017-01-09 08:26:55 EST
(In reply to Peter Cigehn from comment #1)

Thanks Peter,

Unfortunately, inline editing does not seem to work for me when I try just clicking on the element in the model explorer (short click, long click, double click, alt-click), which is one way I would expect inline editing to work - should it?

And yes, F2 does work (FYI, it could be Fn-F2 on Mac depending on settings).

I also think that having a context menu option for this is required - not everyone has the same editing workflow and getting the context menu, I believe, is a common way of getting to such an action as renaming (or editing).

I do like the idea of "edit" instead of "rename".
Comment 3 Peter Cigehn CLA 2017-01-09 10:01:59 EST
(In reply to Charles Rivet from comment #2)
> (In reply to Peter Cigehn from comment #1)
> Unfortunately, inline editing does not seem to work for me when I try just
> clicking on the element in the model explorer (short click, long click,
> double click, alt-click), which is one way I would expect inline editing to
> work - should it?

Nope, that is not how I think it is expected to work in the model explorer,  and actually not in the legacy tooling either. I've tried similar gestures there as well, and it does not enter "edit mode" unless you select the "Edit" menu choice on the context menu. 

This I guess could be up for discussion, but the only way (currently) to enter edit mode is to press F2. However, the most common use of inline editing is of course directly after you have created an element, which is exactly what Bug 492356 is all about, where you should enter edit mode automatically.

> 
> And yes, F2 does work (FYI, it could be Fn-F2 on Mac depending on settings).
> 
> I also think that having a context menu option for this is required - not
> everyone has the same editing workflow and getting the context menu, I
> believe, is a common way of getting to such an action as renaming (or
> editing).
> 
> I do like the idea of "edit" instead of "rename".

Personally I agree that it should be possible to enter "edit mode" using a menu choice on the context menu, exactly as in the legacy tooling. As I said, I am not fully sure why the menu choice "got lost" in base Papyrus when the inline editing was introduced, but it was probably due to someone felt that "Rename" became too specific since the inline editors are able to edit all kinds of stuff (try it for example on an ordinary attribute where the inline editor grammar allows you to edit a lot of the properties for an attribute apart from just its name, e.g. visibility, type, ordered, unique and so on). I guess that this really needs fixing in base Papyrus (or if it is possible to add the menu choice as a work around in Papyrus-RT only).
Comment 4 Charles Rivet CLA 2017-01-09 10:46:00 EST
(In reply to Peter Cigehn from comment #3)
> (In reply to Charles Rivet from comment #2)
> > (In reply to Peter Cigehn from comment #1)
> > Unfortunately, inline editing does not seem to work for me when I try just
> > clicking on the element in the model explorer (short click, long click,
> > double click, alt-click), which is one way I would expect inline editing to
> > work - should it?
> 
> Nope, that is not how I think it is expected to work in the model explorer, 
> and actually not in the legacy tooling either. I've tried similar gestures
> there as well, and it does not enter "edit mode" unless you select the
> "Edit" menu choice on the context menu.

I should have been clearer in my statement. My OS allows click to rename and other "competitive" modeling tools not based on Eclipse and non-UML modeling tools also allow this. My expectations, as stated above, reflected the tools I use, not only Papyrus.

> 
> This I guess could be up for discussion, but the only way (currently) to
> enter edit mode is to press F2. However, the most common use of inline
> editing is of course directly after you have created an element, which is
> exactly what Bug 492356 is all about, where you should enter edit mode
> automatically.
> 
> > 
> > And yes, F2 does work (FYI, it could be Fn-F2 on Mac depending on settings).
> > 
> > I also think that having a context menu option for this is required - not
> > everyone has the same editing workflow and getting the context menu, I
> > believe, is a common way of getting to such an action as renaming (or
> > editing).
> > 
> > I do like the idea of "edit" instead of "rename".
> 
> Personally I agree that it should be possible to enter "edit mode" using a
> menu choice on the context menu, exactly as in the legacy tooling. As I
> said, I am not fully sure why the menu choice "got lost" in base Papyrus
> when the inline editing was introduced, but it was probably due to someone
> felt that "Rename" became too specific since the inline editors are able to
> edit all kinds of stuff (try it for example on an ordinary attribute where
> the inline editor grammar allows you to edit a lot of the properties for an
> attribute apart from just its name, e.g. visibility, type, ordered, unique
> and so on). I guess that this really needs fixing in base Papyrus (or if it
> is possible to add the menu choice as a workaround in Papyrus-RT only).

I just checked and this is something new in Papyrus Neon.2.

I found Papyrus Bug 509357 that deals with this, added to dependencies.
Comment 5 Peter Cigehn CLA 2017-04-19 04:02:26 EDT
This is now fixed in base Papyrus on the Oxygen track. Awaiting migration to Oxygen so that it can be verified in the context of Papyrus-RT.
Comment 6 Peter Cigehn CLA 2017-05-12 08:28:25 EDT
This is now fixed in the latest Papyrus-RT build (#652) based on Papyrus Oxygen.
Comment 7 Peter Cigehn CLA 2017-05-12 08:30:14 EDT
Verified to be fixed in the latest Papyrus-RT build (#652). The "Rename" menu choice are now back on the right-click context menu in the model explorer. When using this menu choice, the direct (inline) editor is activated so that the model element can be renamed.

Leaving in state verified fixed, and Charles can close (or reopen if needed).
Comment 8 Charles Rivet CLA 2017-05-12 15:50:27 EDT
I concur with Peter's comment - closing
Comment 9 Peter Cigehn CLA 2017-05-15 03:04:27 EDT
(In reply to Charles Rivet from comment #8)
> I concur with Peter's comment - closing

Also changing the state to CLOSED.