Bug 509247 - Cleaning up all warnings about try-with-resources
Summary: Cleaning up all warnings about try-with-resources
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-14 14:29 EST by Olivier Thomann CLA
Modified: 2019-05-19 17:31 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (92.92 KB, patch)
2016-12-14 14:31 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2016-12-14 14:29:45 EST 
The patch I will attach cleans up all warnings about try-with-resources. I also noticed that the jar in jar loader code is still compiled using target 1.1 and source 1.3. Any reason for that when all Eclipse bundles now have EE 1.7 at least?
Comment 1 Olivier Thomann CLA 2016-12-14 14:31:01 EST 
Created attachment 265890 [details]
Proposed patch

Hopefully it can apply on master. I also have other changes in my workspace for the bug 508777. So if it does apply, I should apply once the gerrit review for bug 508777 is delivered.
Comment 2 Dani Megert CLA 2016-12-15 13:28:57 EST 
Noopur might try to look at this but it's not a top priority at the moment as it does not bring any immediate benefit to our users.

In the meantime, please upload a Gerrit change instead of a patch. Thanks.

NOTE: The code in the 'jar in jar loader' must not be changed it needs to compile with
	source="1.3"
	target="1.1"
Comment 3 Olivier Thomann CLA 2016-12-15 16:00:54 EST 
I will upload the gerrit change once the previous one is done to make sure they don't collide.
Comment 4 Stephan Herrmann CLA 2017-08-31 06:42:31 EDT 
I too, stumbled upon several such warnings in JDT/UI code. Will clean up post Java 9 GA.
Comment 5 Stephan Herrmann CLA 2017-12-03 17:51:00 EST 
I'm running out of time for M4 - bulk move to M5
Comment 6 Stephan Herrmann CLA 2019-05-19 17:31:57 EDT 
Sorry for holding on to this bug for so long without actually working on it ...