Bug 509243 - [Table] Extra empty spaces added below the table inside the table group
Summary: [Table] Extra empty spaces added below the table inside the table group
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Table (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 3.0.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: blockingpapyrusrt
Keywords:
Depends on:
Blocks: 509245
  Show dependency tree
 
Reported: 2016-12-14 13:31 EST by Young-Soo Roh CLA
Modified: 2017-05-10 04:22 EDT (History)
4 users (show)

See Also:

Attachments
table snapshot (73.92 KB, image/jpeg)
2016-12-14 13:31 EST, Young-Soo Roh CLA 		no flags Details
Empty table in properties (14.65 KB, image/png)
2017-01-04 11:11 EST, Nicolas FAUVERGUE CLA 		no flags Details
Fill table in properties (14.97 KB, image/png)
2017-01-04 11:12 EST, Nicolas FAUVERGUE CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Young-Soo Roh CLA 2016-12-14 13:31:22 EST 
Created attachment 265888 [details]
table snapshot

o.e.p.uml.properties.widgets.NattablePropertyEditor creates a SWT group then place nattable table inside it. When adding more elements to the table extra unused spaces are added below the table once the properties page refreshed. i.e., click different element from model explorer and then click back original element. I think table size calculation should be updated to fix this issue.

Snapshot of property view is attached.
Comment 1 Peter Cigehn CLA 2016-12-15 03:34:45 EST 
It should also be noted that the number of empty rows seem to be related to the number of rows that the table already have, i.e. the more rows the table have, the more empty rows are added, causing the table (including the empty rows) to grow exponentially. It should be sufficient to add a fixed number of empty rows, e.g. one empty row, in the same way as how ordinary lists behaves in the Papyrus properties view.
Comment 2 Nicolas FAUVERGUE CLA 2017-01-04 11:11:55 EST 
Created attachment 266116 [details]
Empty table in properties
Comment 3 Nicolas FAUVERGUE CLA 2017-01-04 11:12:18 EST 
Created attachment 266117 [details]
Fill table in properties
Comment 4 Nicolas FAUVERGUE CLA 2017-01-04 11:12:34 EST 
After investigation and some tests, this bug seems to be already fixed on the last neon (and oxygen) version.
See the two attachments (2 and 3).
Comment 5 Young-Soo Roh CLA 2017-01-04 11:52:38 EST 
(In reply to Nicolas FAUVERGUE from comment #4)
> After investigation and some tests, this bug seems to be already fixed on
> the last neon (and oxygen) version.
> See the two attachments (2 and 3).

Have you tried to click on the different type of element and come back to the element you were testing??  If you click different item with same type then the page does not refresh and no spaces may appear.
Comment 6 Nicolas FAUVERGUE CLA 2017-01-05 09:41:36 EST 
Indeed, if we click on same type of the selected item, the layout is not recalculated, only the data are updated, i will take a look at this problem.
Comment 7 Eclipse Genie CLA 2017-01-05 12:37:31 EST 
New Gerrit change created: https://git.eclipse.org/r/88111
Comment 9 Eclipse Genie CLA 2017-01-06 10:08:09 EST 
New Gerrit change created: https://git.eclipse.org/r/88175
Comment 10 Eclipse Genie CLA 2017-01-06 10:14:05 EST 
New Gerrit change created: https://git.eclipse.org/r/88179
Comment 11 Eclipse Genie CLA 2017-01-26 08:44:38 EST 
Gerrit change https://git.eclipse.org/r/88175 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=35f0174eba93389b1486574f910f9ea44ff477a2
Comment 12 Vincent Lorenzo CLA 2017-01-26 08:45:18 EST 
This bug can now be marked as resolved fixed.