Community
Participate
Working Groups
It's not uncommon for me to want to checkout the code from a review multiple times. When the "Fetch" button is clicked in the reviews editor it always attempts to fetch the patch set and create a new branch for it. It would be nice for it to offer to change to the patch set branch if it sees a branch with a conflicting name during fetch. If a user turns down this offer the previous workflow would resume allowing the user to checkout the patch set to a different branch.
The fetch dialog comes from EGit so I'm moving this there.
Thanks Sam
EGit has no review editor so I am not sure what you are describing here. I also don't understand what stops you from checking out the same branch multiple times. What do you mean with a "conflicting branch". Can you provide detailed steps to reproduce the problem you see ?
Hi Matthias, this was initially reported to Mylyn, hence the description about the review editor. Mylyn reviews uses the FetchGerritChangeWizard to checkout patch sets from gerrit reviews. If this wizard is invoked twice the second time it will open and tell the user that they already have a branch with the given refname. It would be nice if when a user hits this condition the wizard were to show a page prompting them to change to that branch. I'm sure there are ways to reproduce this with just egit, but I will give some simple steps to reproduce via Mylyn since that is how I am familiar with this wizard. Steps to reproduce: * Open a gerrit review with Mylyn * choose a patch set and click "Fetch..." * complete the fetch wizard * change to some other branch (eg. master) * open the same review and click "Fetch..." on the same patch set * the fetch wizard opens and warns the user that there is already a branch with the given name I would be interested in contributing this functionality if you believe it makes sense for eGit.
(In reply to Jaxsun McCarthy Huggan from comment #4) > Hi Matthias, this was initially reported to Mylyn, hence the description > about the review editor. > > Mylyn reviews uses the FetchGerritChangeWizard to checkout patch sets from > gerrit reviews. If this wizard is invoked twice the second time it will open > and tell the user that they already have a branch with the given refname. It > would be nice if when a user hits this condition the wizard were to show a > page prompting them to change to that branch. ok, understood > I'm sure there are ways to reproduce this with just egit, but I will give > some simple steps to reproduce via Mylyn since that is how I am familiar > with this wizard. > > Steps to reproduce: > * Open a gerrit review with Mylyn > * choose a patch set and click "Fetch..." > * complete the fetch wizard > * change to some other branch (eg. master) > * open the same review and click "Fetch..." on the same patch set > * the fetch wizard opens and warns the user that there is already a branch > with the given name > > I would be interested in contributing this functionality if you believe it > makes sense for eGit. yes, this would be useful. I think we should check if the local branch still points at the same commit you would download using the wizard. The user may for example have rebased the branch locally. Maybe it would make sense to warn the user if the commit is not the original one. I'd appreciate your contribution, please follow the contributor guide [1]. [1] https://wiki.eclipse.org/EGit/Contributor_Guide#Contributing_Patches
New Gerrit change created: https://git.eclipse.org/r/87372
Gerrit change https://git.eclipse.org/r/87372 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=4c6fe7070d5802a7c189a360d0cfbaeb565e20b1
"Fetch from gerrit" doesn't do anything useful anymore as soon as the "checkout new branch" is selected. This is a blocker => reopening.
(In reply to Andrey Loskutov from comment #8) > "Fetch from gerrit" doesn't do anything useful anymore as soon as the > "checkout new branch" is selected. This is a blocker => reopening. if we don't get a fix quickly we should revert this change until a fixed version is available
(In reply to Matthias Sohn from comment #9) > (In reply to Andrey Loskutov from comment #8) > > "Fetch from gerrit" doesn't do anything useful anymore as soon as the > > "checkout new branch" is selected. This is a blocker => reopening. > > if we don't get a fix quickly we should revert this change until a fixed > version is available I've tried to fix it but I can't debug right now because something is broken in my M6 workspace - I can't use context menus and get only StackOverflows... So please revert, because a simple gerrit patch checkout is not possible anymore.
New Gerrit change created: https://git.eclipse.org/r/93183
(In reply to Eclipse Genie from comment #11) > New Gerrit change created: https://git.eclipse.org/r/93183 I'm reverting the change. I've tried to fix it but the whole handling of those connected radio buttons is broken with this, and currently I can't fetch anymore.
Gerrit change https://git.eclipse.org/r/93183 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=49c363c7d6cfe107cfada512ee8e6efcb98ea2b6
