Bug 509068 - [Papyrus] Overriding CSS style gives unexplained EAnnotation addition in Comparison editor
Summary: [Papyrus] Overriding CSS style gives unexplained EAnnotation addition in Comp...
Status: ASSIGNED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Simon Delisle CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 07:14 EST by Thomas Wiman CLA
Modified: 2017-01-10 09:22 EST (History)
2 users (show)

See Also:


Attachments
Gitrepo and Screenshot (79.61 KB, application/x-zip-compressed)
2016-12-12 07:14 EST, Thomas Wiman CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Wiman CLA 2016-12-12 07:14:50 EST
Created attachment 265829 [details]
Gitrepo and Screenshot

Manual formatting overriding an applied CSS style sheet are stored as EAnnotations with the source id "PapyrusCSSForceValue".
That means that EMF compare will report a formatting change as an addition-difference which make it difficult to separate it from "real" additions of elements to a diagram.
I really think that the end user should not be exposed to the concept of EAnnotations. It is necessary to have some kind of alternative presentation of EAnnotation differences in the comparison editor. Probably something that has CSS awareness and can present CSS overriding Constructions (stored as EAnnotations) in a user-friendly way.  


Attached you will find a zip-file containing a screenshot of the Comparison editor and a Git repo with one commit that contains a minimal CSS-file and a model with three classes and a class diagram that make use of the CSS-file.

After the commit, the model´s diagram has been modified (but not yet commited)as follow:
•Class1 shape is untouched
•Class2 shape has been set to bold by pressing the bold-button in the property view
•Class3 shape has been set to bold by using the Font dialog (Diagram->Font... submenu)

If you compare the modified .notation file with the commited, you will get the result as shown in the attached screenshoot in the zip-file. 

It is impossible to understand in the comparison editor what the EAnnotation represents as it can´t be expanded further. I would prefer that the additon of the EAnnottion has been hided in the comparison editor or that it has been further detailed, so it could be understood.
Comment 1 Eclipse Genie CLA 2017-01-09 14:24:37 EST
New Gerrit change created: https://git.eclipse.org/r/88297