Bug 50898 - Javadoc AST: Missing binding for reference to non-visible type
Summary: Javadoc AST: Missing binding for reference to non-visible type
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-29 14:25 EST by Martin Aeschlimann CLA
Modified: 2004-02-11 11:57 EST (History)
2 users (show)

See Also:

Attachments
Possible fix (737 bytes, patch)
2004-01-29 16:26 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2004-01-29 14:25:22 EST 
20040128 5pm preview

Refernecs to non-visible types don't offer a binding: G.Inner has no binding.
In the code, also non-visible references have bindings
(We need it to offer a quick fix)

(minor)

public class E {
	
    /**			
     * @see G.Inner
     */
    public void gee() {
    }
}

class G {
	private static class Inner {}
}
Comment 1 Frederic Fusier CLA 2004-01-29 16:26:19 EST 
Created attachment 7635 [details]
Possible fix

Of course not for tomorrow, but Philippe what do you think about this change?
Comment 2 Frederic Fusier CLA 2004-01-29 16:27:24 EST 
I missed the CC while attaching the patch...
Comment 3 Philipe Mulet CLA 2004-01-30 10:34:31 EST 
Re:patch, I would only copy the original into the new problem reference binding.
Kent - do you have an opinion on the best way to propagate the original 
binding ?
Comment 4 Frederic Fusier CLA 2004-02-04 14:23:50 EST 
Fixed.
Now we return a binding also for non-visible references.

[jdt-core internal]
As proposed by Philippe, we just set the original binding on new problem 
reference binding. This allow DefaultBindingResolver to retrieve it.
Change made in getType(char[][]) method of Scope.

Test case to be added...
Comment 5 Frederic Fusier CLA 2004-02-05 10:41:33 EST 
Test case added in jdt.core.dom.tests.ASTConverterJavadocTest
Comment 6 David Audel CLA 2004-02-11 11:57:24 EST 
Verified for 3.0M7