Bug 508868 - DOT Graph View - Dot2ZestAttributesConverter needs to properly handle EscString values
Summary: DOT Graph View - Dot2ZestAttributesConverter needs to properly handle EscStri...
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF DOT (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 507413
Blocks:
  Show dependency tree
 
Reported: 2016-12-08 01:54 EST by Alexander Nyßen CLA
Modified: 2020-02-20 11:32 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2016-12-08 01:54:56 EST
While labels that equal "\G","\N", and "\E" values already, there is no proper handling of EscString values. That is, the escape sequences will not be replaced when being embedded in a string, and other escape sequences (e.g. "\n") are not translated at all.
Comment 1 Zoey Gerrit Prigge CLA 2019-03-26 12:58:45 EDT
Updating this bug, we should note that there was a discussion on which of such strings to replace and where to replace them in bug #508830.

Furthermore, we introduced all EscString values other than proper EscString newline support, as far as I can see, in bug #534707 - sorry for not noticing this bug at the time...

What thus remains to be introduced in Dot Graph View is newline justification and hence "\l", "\r" escape sequences.
Comment 2 Zoey Gerrit Prigge CLA 2020-02-20 11:32:58 EST
I pushed a commit with the following changes to the master branch:

[508868] Adapt linebreak decode to also honour "\l" and "\r"

-adapt decodeLineBreak method in Dot2ZestAttributeConverter to also
convert "\r" and "\l" linebreaks
-disregard final linebreak character (signifies line orientation only)
-does not offer full linebreak support, as we currently do not honour
implied justification setting


As mentioned, there is not yet support for line justification based on EscString newline sequences. We had hence not yet implemented this (I changed the TODO appropriately). However, wrongly justified text seems better than to not handle the newline escape sequences at all.

Correct justification however, requires changes in Zest, as the JavaFX Text class does not allow seperate styles for each line/paragraph.

Leaving the bug open.