Community
Participate
Working Groups
It has been years since we updates CSSLint and there are many improvements we could take advantage of.
Here's the diff from current master to what we are consuming: https://github.com/CSSLint/csslint/compare/v0.10.0...master there is a lot of improvements to the project shape / package.json / build / code formatting, but not much in the way of tooling improvement.
Parser-lib has major changes to its known properties to support CSS3 and SVG. The built library increased by 1500 LoC (~10800 long now).
Another change is the addition of ignore directives that disable the linting for parts of your file. https://github.com/CSSLint/csslint/wiki/Ignoring-parts-of-CSS-during-linting
Confirmed that the 1.0.4 dist is compatible with our current code. We will have to modify it to: a) export colours b) allow NLS of messages c) possible line ending problems d) export the ast e) don't fail on no source f) possible tokenizer changes? g) change severity to INFO Opened a CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12779
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/?h=cwindatt%2FBug508847_CSSLint104 CQ was approved and I have redone our customizations. Orion git client was having a problem resetting the active branch, so for now I put the changes into a branch. As far as I can tell, the new version is ready to go live. > a) export colours Done > b) allow NLS of messages Done, nls existing, added 2, changed text of one > c) possible line ending problems Done > d) export the ast Done, but there are new node types we should handle in the future > e) don't fail on no source Done > f) possible tokenizer changes? Done see (d) > g) change severity to INFO Done h) Update tests to not have a syntax error (undetectable in previous csslint version) Done i) SVG properties Already handled in this version
As rules were added and updated, I will need to review our settings in webtoolsplugin.js and the matching config properties in cssvalidator.js. Also after the update we will try to improve the messages and severities. See Bug 513250.
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2a1096872c3dc13a44e1f467a1ec6e9b537cabbe http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bc15f87459770cbc866b4c65f99eeec9b3b7cafa http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e74b6267085263cc898fe0674ec27bfdf153ba25 http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6e57be60d329bd84f0b1aca36044afa5e8b3deb6 Cherry picked the commits from my working branch onto master for 15.0.
