Bug 508703 - Cross file tests are broken by new resolver plugin
Summary: Cross file tests are broken by new resolver plugin
Status: CLOSED WONTFIX
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: 13.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 493582
Blocks:
  Show dependency tree
 
Reported: 2016-12-05 16:52 EST by Curtis Windatt CLA
Modified: 2018-04-09 09:36 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2016-12-05 16:52:55 EST
Caused by Bug 493582.

I have disabled our cross file test suite and a number of the validator tests as well.  We have three ways we create files for the tests and two of them are broken with the resolver.

1) Cross file test suite
Here we include the files in the workspace and the testingWorker translates the url.
With the new resolver plugin the read never finishes resulting in a test that times out.

2) Content assist tests
Here we create fake data in the testingworker so when Tern calls for a read we return the fake data.  This works fine with the new resolver.

3) Validator tests
Here we call addFile() directly on the worker.  The new resolver plug-in never is called in this scenario.
Comment 1 Curtis Windatt CLA 2016-12-06 15:36:54 EST
http://git.eclipse.org/c/gerrit/orion/org.eclipse.orion.client.git/commit/?id=7218e100ca2e67673326bc9a3bc3ff917c74d595
Fixed in master

The files were being analyzed in the wrong scope resulting in the test failures.  However, I'm not sure why that resulted in the cross file test suite hanging (waiting on a pending read).
Comment 2 Curtis Windatt CLA 2016-12-06 16:52:18 EST
Reopening as I ran into the cross file suite hanging issue again.
Comment 3 Michael Rennie CLA 2018-04-09 09:36:39 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. 

For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04114.html