508145 – Remove Non-Javadoc statements from PDE UI

Bug 508145 - Remove Non-Javadoc statements from PDE UI

Summary: Remove Non-Javadoc statements from PDE UI

Status:	VERIFIED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.5
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.11
Assignee:	Julian Honnen
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, helpwanted

Depends on:
Blocks:

Reported:	2016-11-24 12:06 EST by Lars Vogel
Modified:	2019-01-07 05:23 EST (History)
CC List:	5 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-11-24 12:06:37 EST

We still have useless Non-Javadoc statements in PDE, see https://git.eclipse.org/r/#/c/85630/1/ua/org.eclipse.pde.ua.core/src/org/eclipse/pde/internal/ua/core/toc/text/TocAnchor.java

We should remove them. Tooling from https://github.com/vogellacompany/codemodify might be useful for that.

Comment 1 Lars Vogel

2017-07-21 04:33:05 EDT

To find them, perform a text search for

--
/*
		 * @see
--

Comment 2 Vikas Chandra

2018-03-13 04:47:36 EDT

Moving out of 4.8. If you plan for 4.8, please triage back with a patch.

Comment 3 Lars Vogel

2018-11-15 10:03:50 EST

Julian, can you take this one? This bug is old, it was created before we decided that we do not need bug reports for cleanup work.

Comment 4 Eclipse Genie

2018-11-20 08:29:54 EST

New Gerrit change created: https://git.eclipse.org/r/132750

Comment 5 Eclipse Genie

2018-11-20 08:33:13 EST

New Gerrit change created: https://git.eclipse.org/r/132752

Comment 6 Eclipse Genie

2018-11-20 08:33:15 EST

New Gerrit change created: https://git.eclipse.org/r/132753

Comment 7 Eclipse Genie

2018-12-12 04:06:55 EST

Gerrit change https://git.eclipse.org/r/132750 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=aa3ca69351b69e89bf5f77b00886fea9a3fa40a5

Comment 8 Eclipse Genie

2018-12-12 04:07:37 EST

Gerrit change https://git.eclipse.org/r/132753 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a0b2b78c885a8238f4de99a6ac85387868773219

Comment 9 Lars Vogel

2018-12-12 04:31:25 EST

Thanks Julian.

Comment 10 Eclipse Genie

2018-12-12 04:31:34 EST

Gerrit change https://git.eclipse.org/r/132752 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d8cb7b46d53730c1f0083d65516929fcb6ff8a8c

Comment 11 Vikas Chandra

2019-01-07 04:59:16 EST

Julian/Lars, can you please verify this defect?