Community
Participate
Working Groups
If possible, please do not use the html title attribute - please use the green Orion tooltip. Something like: define([ ..., 'i18n!orion/settings/nls/messages', ... 'orion/webui/tooltip', ...], function(..., messages, ..., mTooltip, ...) { ... new mTooltip.Tooltip({ node: backButtonNode, // or forwardButtonNode or refreshButtonNode text: messages.back, // or messages.forward or messages.refresh position: ['above', 'right', 'below', 'left'] //$NON-NLS-3$ //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$ }); ... (if those buttons are ever destroyed, then need to save and .destroy(); the tooltip when the button is destroyed)
New Gerrit change created: https://git.eclipse.org/r/85700
Currently, there's no walk around for the Electron UI code to get access to Orion Client code, so we can not use any of the Orion Client code. The only way to show a green Orion look tooltip is re-implement the same code for Electron UI code, but for now, we stick to "title" attribute.
Ok for now, but if we use title, we need to also do one more thing, because title attribute is not considered to be accessible. So we need to also add an "aria-label" that has the same text as the title attribute. For example: var backLabel = "Back"; // should nls, i.e. messages["back"] or messages.back back.title = backLabel; back.setAttribute("aria-label", backLabel); (note that all aria-* attributes need to be set with setAttribute - they cannot be set with dot notation. Someday, that will be fixed, but not today <g>)
Gerrit change https://git.eclipse.org/r/85700 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1e6f0bbc6005a98e018d4dcb723189b04406136b
I merged the original fix and then added the aria-label attributes with: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=8c727978693062a094c07fc21fb64dcc5f07c438
