Community
Participate
Working Groups
First iteration would contain support for simple IU autocomplete and syntax highlighting.
New Gerrit change created: https://git.eclipse.org/r/85954
Demo of what the above gerrit can do: https://sopotc.fedorapeople.org/Screencast%20from%2011-28-2016%2005:21:39%20PM.webm
The feature looks good and in a new target file it seems to work great !! However with 85954/5, I found the following issues ---------------------------------------------------- 1) This doesn't work on old target editor files. The reason is that auto completion expects <?xml version="1.0" encoding="UTF-8" standalone="no"?> <?pde version="3.8"?><target name="org.eclipse.orion" s> </target> doesn't work but <?xml version="1.0" encoding="UTF-8" standalone="no"?> <?pde version="3.8"?> <target name="org.eclipse.orion" s> </target> works. When PDE create a target editor, it is in a formatting that resembles the former. 2) Lot of places needs //$NON-NLS-1$ addition for example see below handyAddition = "</" + tags[i] + ">"; 3) Dependencies should have range till upto Require-Bundle: org.eclipse.core.runtime, org.eclipse.jface.text, org.eclipse.ui.genericeditor, org.eclipse.pde;bundle-version="3.13.0", org.eclipse.pde.ui;bundle-version="3.10.0", org.eclipse.equinox.p2.metadata;bundle-version="2.3.100", org.eclipse.equinox.p2.core;bundle-version="2.4.100", org.eclipse.equinox.p2.repository;bundle-version="2.3.200", org.eclipse.ui;bundle-version="3.109.0", something like org.eclipse.ui.forms;bundle-version="[3.2.0,4.0.0)", Else there will be breakage once once of the plugins upgrade even their micro version number. 4) Setting should be in accordance with rest of pde .settings\org.eclipse.jdt.ui.prefs \.settings\org.eclipse.jdt.core.prefs See org.eclipse.pde.ds.annotations(which was recently added) or any other pde plugin.
Vikas, thank you for the review. I addressed all your concerns in a new patchset in the same gerrit. Now autocomplete should work even if you want all your target file in one single line. Please review it there so we don't have to hop back and forth between the bug and the gerrit. Also we need a decision on the CQ story there. Thanks.
Vikas, would you please answer whether CQ will be needed and if yes filing one so this doesn't get delayed by this too.
Gerrit change https://git.eclipse.org/r/85954 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4fe74bf6d92e21e025b877f439ffcc6bf3b6cd86
Alex, a CQ is not needed. Thanks Sopot ! Looking forward to further enhancing this and providing support for other PDE editors too. Sopot, can you update the N&N for pde.
New Gerrit change created: https://git.eclipse.org/r/88654
(In reply to Vikas Chandra from comment #7) > Thanks Sopot ! Thanks to you and Lars for reviewing. > Sopot, can you update the N&N for pde. Done, see comment 8.
The N&N item looks good.
Gerrit change https://git.eclipse.org/r/88654 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8aba43529aab09a01f6ddc21d45ee53fff7af786
(In reply to Vikas Chandra from comment #10) > The N&N item looks good. Merged.
Works well on Version: Oxygen (4.7) Build id: I20170113-2000
verified on Version: Oxygen (4.7) Build id: I20170123-2000
