Description Martin Karpisek 2016-11-19 16:53:58 EST

Cleanup PDE code warnings

This bug is to propose patches for reducing amount of warnings in current PDE codebase 
(for all pde projects, which seems to be currently ~ 1126 warnings)
Target would be to make more easy further bugfixing and contributing (while removing basic issues first).

Proposed steps:
- fix deprecated java code
- generify where possible (warnings are mostly in runtime)
- fix javadoc problems found (bug 275738)
- replace non-javadoc comment with @override annotation => enable save action for missing code annotations
- introduce foreach loop for iterating over arrays (instead of clasic for)
- increase all PDE plugins to be execution environment=1.8 (if not some issue to raise minimal requirements) 
	currently launching=1.7, ua.core=1.4, ua.test=1.5, ui.trace=1.5, otherwise all are 1.8
- fix deprecated extension points usage (where possible, part of it is to address also bug 246590 and bug 390980)

Proposed approach: 
- i would prepare patches for steps above one by one during remaining 4.7 timeframe (as time permits)
- scope of this bug is cleanup - which would be easy to review - not rewrite or change of functionality
- for each item above i would create separate bug and relate to this umbrella one  
- each cleaned-up project would have own patch (gerrit review) for the fixed kind of problem

Please review and comment, especially approach above (to make it easy for review).