Bug 507516 - Poor copy detection result
Summary: Poor copy detection result
Status: NEW
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 19:39 EST by Dave Borowitz CLA
Modified: 2016-11-14 19:39 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Borowitz CLA 2016-11-14 19:39:09 EST
JGit 881e6b2cbbba61669f9ac83e357f141743c5305a

Originally reported at https://bugs.chromium.org/p/gerrit/issues/detail?id=4907, but this is a JGit issue, not a Gerrit issue.

Gerrit runs JGit rename detection on the following change:
https://chromium-review.googlesource.com/#/c/402073/11

This is a poor choice for a copy source:
https://chromium-review.googlesource.com/#/c/402073/11/plat/rockchip/rk3399/drivers/m0/src/suspend.c
similarity index 76%
copy from plat/rockchip/rk3399/drivers/m0/src/rk3399m0.ld
copy to plat/rockchip/rk3399/drivers/m0/src/suspend.c

C git does much better here, detecting the copy from main.c:

$ git log -B -M -C --numstat -1 --find-copies-harder 39c3d5d9e17640143598fa6caf4c34eb27b7ca11
commit 39c3d5d9e17640143598fa6caf4c34eb27b7ca11
Author: Xing Zheng <zhengxing@rock-chips.com>
Date:   Wed Oct 26 21:25:26 2016 +0800

    rk3399: dram: use PMU M0 to do ddr frequency scaling

    We used dcf do ddr frequency scaling, but we just include a dcf
    binary, it hard to maintain later, we have M0 compile flow in ATF,
    and M0 can also work for ddr frequency scaling, so let's use it.

    Change-Id: Ib554f06dad4b4510d055a5291cd3ac476a31ebcd
    Signed-off-by: Lin Huang <hl@rock-chips.com>
    Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

1 0 plat/rockchip/common/include/plat_private.h
5 0 plat/rockchip/common/pmusram/pmu_sram.c
0 386 plat/rockchip/rk3399/drivers/dram/dcf_code.inc
27  96  plat/rockchip/rk3399/drivers/dram/dfs.c
0 1 plat/rockchip/rk3399/drivers/dram/dfs.h
11  3 plat/rockchip/rk3399/drivers/m0/Makefile
21  3 plat/rockchip/rk3399/drivers/m0/include/rk3399_mcu.h
225 0 plat/rockchip/rk3399/drivers/m0/src/dram.c
13  33  plat/rockchip/rk3399/drivers/m0/src/main.c
4 0 plat/rockchip/rk3399/drivers/m0/src/{rk3399m0.ld => rk3399m0.ld.S}
3 20  plat/rockchip/rk3399/drivers/m0/src/{main.c => suspend.c}
109 0 plat/rockchip/rk3399/drivers/pmu/m0_ctl.c
11  6 include/drivers/arm/pl061_gpio.h => plat/rockchip/rk3399/drivers/pmu/m0_ctl.h
5 35  plat/rockchip/rk3399/drivers/pmu/pmu.c
0 10  plat/rockchip/rk3399/drivers/pmu/rk3399m0.h
3 16  plat/rockchip/rk3399/drivers/soc/soc.c
12  0 plat/rockchip/rk3399/drivers/soc/soc.h
27  32  tools/fiptool/fiptool.h => plat/rockchip/rk3399/include/shared/m0_param.h
0 3 plat/rockchip/rk3399/plat_sip_calls.c
3 1 plat/rockchip/rk3399/platform.m