Bug 506791 - Investigate extraction of ComputationParametersProvider from IConnectionRouter
Summary: Investigate extraction of ComputationParametersProvider from IConnectionRouter
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF FX (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 09:29 EDT by Matthias Wienand CLA
Modified: 2016-10-31 09:29 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Wienand CLA 2016-10-31 09:29:07 EDT 
Currently, the IConnectionRouter is responsible for providing the computation parameters for an AnchorKey of a Connection. However, the router should only insert control points where needed, and providing computation parameters is independent from that.

In the case of the "Dot Graph View", the dot-provided start and end points should be used as anchored reference points regardless of the used router, i.e. for orthogonal and straight routing, the same parameters need to be provided to the strategy. Therefore, we should rethink the coupling between IConnectionRouter and IComputationStrategy.

Moreover, the only place where the router is used to compute parameters is within Connection. Therefore, introducing a new concept that is used by Connection would not be problematic.