Community
Participate
Working Groups
The p2 install dialog can sometimes take very long (depending on network performance). It would be better to have it non-model so user could still spend time on their editors while p2 is doing stuff.
New Gerrit change created: https://git.eclipse.org/r/83807
Gerrit change https://git.eclipse.org/r/83807 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=c032cd7c1538834686a9f16c203a9094084631d8
Thanks Stefan for the merge. This will also allow to open the dialog multiple times, so that the user can load and browse several repositories at the same time. N&N entry upcoming.
New Gerrit change created: https://git.eclipse.org/r/84613
Gerrit change https://git.eclipse.org/r/84613 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=b0cbcb4160d46f58ce44c8b514f11fd64aa05fb7
New Gerrit change created: https://git.eclipse.org/r/84630
Gerrit change https://git.eclipse.org/r/84630 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=e5c4235323ad43dfa5aa3aaffa6527de329f994b
(In reply to Lars Vogel from comment #4) > This will also allow to open the dialog multiple times, so that the user can > load and browse several repositories at the same time. How did you ensure that all the p2 infrastructure is ready to deal with concurrent changes to the installed features? Was this properly tested, or was it an unreflected change?
(In reply to Markus Keller from comment #9) > How did you ensure that all the p2 infrastructure is ready to deal with > concurrent changes to the installed features? p2 can only install from one update side, this was not changed. You could do this already before this change, by opening two Eclipse instances and trying to run an install. The second one will fail and report an error. With this change you can browser two or more repositories at the same time. If you found issues the involved parties in this bug have not found, please report them. If necessary this fix might have to reverted.
Mickael / Stefan what do you think about having the option to open the installation dialog several times? Maybe to keep the change to users minimal we should start with only making the dialog non-blocking but disallow opening it several times?
(In reply to Lars Vogel from comment #11) > Mickael / Stefan what do you think about having the option to open the > installation dialog several times? Maybe to keep the change to users minimal > we should start with only making the dialog non-blocking but disallow > opening it several times? I don't think an issue is likely to happen here. Even if doable, I imagine users won't often start multiple install dialog; and even if they do, I don't think it's really an issue and user would easily understand what happened, why and how to avoid or troubleshoot that. AFAIK, p2 has the mechanics to deal with multiple installations with a transaction mechanism, so multiple concurrent wizards would not break it. That said, having a singe installation dialog would probably be a bit nicer, but it's INO not a blocker in term of usability, and AFAIK it's not a technical issue neither.
It sounds like concurrent installs have not been tested and would likely fail, so that part of the N&N should be removed.
(In reply to Markus Keller from comment #13) > It sounds like concurrent installs have not been tested and would likely > fail, so that part of the N&N should be removed. Done.
(In reply to Mickael Istria from comment #12) > That said, having a singe installation dialog would probably be a bit nicer Lets go for nicer. Gerrit review is upcoming.
New Gerrit change created: https://git.eclipse.org/r/84875
Gerrit change https://git.eclipse.org/r/84875 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=ec0e89de420e1c0c3bce490799a7eba44338b294
(In reply to Eclipse Genie from comment #17) > Gerrit change https://git.eclipse.org/r/84875 was merged to [master]. > Commit: > http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/ > ?id=ec0e89de420e1c0c3bce490799a7eba44338b294 Based on this review I am closing as fixed.
This appears to cause bug 520717. I'm thinking we should back this change out.
New Gerrit change created: https://git.eclipse.org/r/110039
New Gerrit change created: https://git.eclipse.org/r/110041
New Gerrit change created: https://git.eclipse.org/r/110040
(In reply to Thomas Watson from comment #19) > This appears to cause bug 520717. I'm thinking we should back this change > out. I have no objections against the revert.
New Gerrit change created: https://git.eclipse.org/r/110060
New Gerrit change created: https://git.eclipse.org/r/110059
New Gerrit change created: https://git.eclipse.org/r/110058
Gerrit change https://git.eclipse.org/r/110059 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=7d19a0b20de1ce741e67669671c4b05815dcac2e
Gerrit change https://git.eclipse.org/r/110058 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=33c7f929c6b197d6f853daf5517ff1ac870a4698
Gerrit change https://git.eclipse.org/r/110060 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=86583602bc6475defa8c68f52455ed3d43b803bb
Gerrit change https://git.eclipse.org/r/110040 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=509a4f86f675935e0a1f5ca19ff11521777c5eb4
Gerrit change https://git.eclipse.org/r/110039 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=fbad4b2ac966a55634f61236416f1b700730929d
Gerrit change https://git.eclipse.org/r/110041 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=2069f2dc0349fd67ac0250346684f547240fcce5
