Bug 506420 - Decorators should not restrict the possibilities to select diagram elements that are beneath
Summary: Decorators should not restrict the possibilities to select diagram elements t...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 4.0.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 5.0.0M7   Edit
Assignee: Project Inbox CLA
QA Contact: Florian Barbin CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-10-24 05:24 EDT by Steve Monnier CLA
Modified: 2017-11-20 05:19 EST (History)
6 users (show)

See Also:

Attachments
Validation.zip (5.24 KB, application/x-zip-compressed)
2017-03-20 07:26 EDT, Laurent Redor CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Monnier CLA 2016-10-24 05:24:26 EDT 
Decorators should not restrict the possibilities to select diagram elements that are beneath. Indeed, it is possible to have a decorator on a node A that is displayed over a node B that is on the border of node A.
Comment 1 Laurent Redor CLA 2016-11-08 04:21:27 EST 
Steve, have you sample (decorators, diagram navigation, ...) or does it need specific PermissionAuthority like in org.eclipse.sirius.tests.swtbot.LockedRepresentationContainerTest, org.eclipse.sirius.tests.swtbot.modelexplorer.LockedModelExplorerTest, ...?

This problem is only for decorators on diagram element or also on diagram?
Comment 3 Laurent Fasani CLA 2016-11-21 10:52:01 EST 
WARNING: This commit in Comment 2 has lead to a regression about tooltip.

Tooltip on validation decorator is not displayed any more. Indeed, draw2D tries to find a figure under the mouse from which he will display the tooltip and he can not find it because this commit redefined the org.eclipse.draw2d.Figure.findFigureAt(int, int, TreeSearch) method returning null.

Moreover, the new SiriusDecoratorEditPolicy has not be applied on the border node EditPart. This should have been because we could border node on border node.
Comment 4 Eclipse Genie CLA 2016-11-23 10:09:58 EST 
New Gerrit change created: https://git.eclipse.org/r/85589
Comment 5 Eclipse Genie CLA 2016-11-23 10:10:01 EST 
New Gerrit change created: https://git.eclipse.org/r/85588
Comment 7 Laurent Redor CLA 2017-03-20 07:26:05 EDT 
Created attachment 267352 [details]
Validation.zip

Steps to reproduce:
* Import project "Validation" from "Validation.zip"
* Open the diagram "new diag"
* Click on the bottom-right corner of the decoration icon about "navigation to new diag2" on root package
* The selected element must be "EClass1Border"
* Launch the action "Validate diagram" (contextual menu on the diagram)
* Click on each "red cross" decorator and ensure that the selected element is the one under the mouse (and not the "parent" of the decorator)
Comment 9 Jessy Mallet CLA 2017-05-15 10:36:51 EDT 
Validated with Sirius 5.0.0.201705121003
Comment 10 Pierre-Charles David CLA 2017-05-17 03:21:35 EDT 
Verified by Jessy.
Comment 11 Pierre-Charles David CLA 2017-06-29 03:33:02 EDT 
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.