506259 – Improve decorator management on diagram elements

Bug 506259 - Improve decorator management on diagram elements

Summary: Improve decorator management on diagram elements

Status:	RESOLVED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	4.1.0
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	5.0.0
Assignee:	Project Inbox
QA Contact:	Pierre-Charles David

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2016-10-20 04:03 EDT by Laurent Fasani
Modified:	2017-10-10 03:23 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Fasani

2016-10-20 04:03:57 EDT

A specification will follow as first commit

Comment 1 Eclipse Genie

2016-11-29 10:29:59 EST

New Gerrit change created: https://git.eclipse.org/r/85949

Comment 2 Eclipse Genie

2016-12-05 11:21:53 EST

New Gerrit change created: https://git.eclipse.org/r/86381

Comment 3 Eclipse Genie

2016-12-14 11:59:51 EST

New Gerrit change created: https://git.eclipse.org/r/87147

Comment 4 Eclipse Genie

2016-12-21 05:33:01 EST

New Gerrit change created: https://git.eclipse.org/r/87532

Comment 5 Eclipse Genie

2016-12-21 11:38:02 EST

New Gerrit change created: https://git.eclipse.org/r/87581

Comment 6 Eclipse Genie

2016-12-22 04:51:22 EST

New Gerrit change created: https://git.eclipse.org/r/87609

Comment 7 Eclipse Genie

2016-12-27 11:16:56 EST

New Gerrit change created: https://git.eclipse.org/r/87762

Comment 8 Eclipse Genie

2016-12-30 11:21:24 EST

New Gerrit change created: https://git.eclipse.org/r/87835

Comment 9 Eclipse Genie

2017-02-08 11:41:20 EST

Gerrit change https://git.eclipse.org/r/85949 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6502a3cb1acd1aac6adbf1f93634ddfe6fc20cf5

Comment 10 Eclipse Genie

2017-02-09 13:02:42 EST

New Gerrit change created: https://git.eclipse.org/r/90762

Comment 11 Eclipse Genie

2017-02-09 13:02:45 EST

New Gerrit change created: https://git.eclipse.org/r/90763

Comment 12 Eclipse Genie

2017-02-10 10:24:45 EST

New Gerrit change created: https://git.eclipse.org/r/90844

Comment 13 Eclipse Genie

2017-02-10 11:33:15 EST

Gerrit change https://git.eclipse.org/r/90762 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ad7959b30bbf91621e9ab7a42c5b59f86e43a83f

Comment 14 Eclipse Genie

2017-02-10 11:33:19 EST

Gerrit change https://git.eclipse.org/r/87609 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bcb5dbeb5fc08118ef7a67de9acf5d3f830c8eb2

Comment 15 Eclipse Genie

2017-02-16 04:20:14 EST

New Gerrit change created: https://git.eclipse.org/r/91256

Comment 16 Eclipse Genie

2017-02-16 04:20:17 EST

New Gerrit change created: https://git.eclipse.org/r/91257

Comment 17 Eclipse Genie

2017-02-17 10:43:06 EST

New Gerrit change created: https://git.eclipse.org/r/91386

Comment 18 Eclipse Genie

2017-02-17 10:43:10 EST

New Gerrit change created: https://git.eclipse.org/r/91385

Comment 19 Eclipse Genie

2017-03-15 05:14:39 EDT

New Gerrit change created: https://git.eclipse.org/r/93093

Comment 20 Eclipse Genie

2017-03-17 13:03:22 EDT

Gerrit change https://git.eclipse.org/r/86381 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=143da7df3e9f586fb3780c4a0837a7b65259483d

Comment 21 Eclipse Genie

2017-03-21 12:30:16 EDT

New Gerrit change created: https://git.eclipse.org/r/93552

Comment 22 Eclipse Genie

2017-04-03 04:20:49 EDT

Gerrit change https://git.eclipse.org/r/93093 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bf422e6ff6bf7eb8d3327e5ab0c873b7d6bddfda

Comment 23 Eclipse Genie

2017-04-03 04:20:53 EDT

Gerrit change https://git.eclipse.org/r/90763 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e091c7318e9d032691f9fbb718ec762ad6e950d1

Comment 24 Eclipse Genie

2017-04-03 04:20:56 EDT

Gerrit change https://git.eclipse.org/r/91386 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d768055c9f19401ebfb8cf5135f72019858443d7

Comment 25 Eclipse Genie

2017-04-03 04:20:59 EDT

Gerrit change https://git.eclipse.org/r/91385 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f647ddd6fa3fa87fbd38f9a1cb2c431977deb165

Comment 26 Eclipse Genie

2017-04-03 04:21:13 EDT

Gerrit change https://git.eclipse.org/r/87835 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1449e3c7daa978f054a976bfdf51ebd1062ae252

Comment 27 Eclipse Genie

2017-04-03 04:21:16 EDT

Gerrit change https://git.eclipse.org/r/91257 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=76e1f9b5cf41c3de2f56c8bbbecaa0e58b192c73

Comment 28 Eclipse Genie

2017-04-03 04:21:20 EDT

Gerrit change https://git.eclipse.org/r/91256 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fe5b012b18b912e7cb12e2318f9c97c4385c5c2b

Comment 29 Eclipse Genie

2017-04-03 04:21:23 EDT

Gerrit change https://git.eclipse.org/r/90844 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5784e5d176f25be9ce125118e89f0ec8b8ab79c5

Comment 30 Eclipse Genie

2017-04-03 04:21:26 EDT

Gerrit change https://git.eclipse.org/r/87762 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=46451c87b0bede64860f5e301675308ea9ce7daa

Comment 31 Eclipse Genie

2017-04-03 04:21:29 EDT

Gerrit change https://git.eclipse.org/r/87581 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d1ebbff1d8d345862989370ca695c39b4feb1ef0

Comment 32 Eclipse Genie

2017-04-03 04:21:32 EDT

Gerrit change https://git.eclipse.org/r/87532 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9c0059527352d1a861dc4d476fb305c8838c1215

Comment 33 Eclipse Genie

2017-04-03 04:21:36 EDT

Gerrit change https://git.eclipse.org/r/87147 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b3e569fc8697dd2f25876a213bea64d4403b8c62

Comment 34 Eclipse Genie

2017-04-03 04:21:45 EDT

Gerrit change https://git.eclipse.org/r/93552 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1480d0eb58e7c669156fa7e3bd894807b0f7b56a

Comment 35 Eclipse Genie

2017-04-04 03:40:24 EDT

New Gerrit change created: https://git.eclipse.org/r/94346

Comment 36 Eclipse Genie

2017-04-04 10:38:59 EDT

New Gerrit change created: https://git.eclipse.org/r/94382

Comment 37 Eclipse Genie

2017-04-04 11:12:09 EDT

New Gerrit change created: https://git.eclipse.org/r/94384

Comment 38 Eclipse Genie

2017-04-05 03:21:22 EDT

Gerrit change https://git.eclipse.org/r/94382 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=054057677242dd9add0f64f162b991cb4354000a

Comment 39 Eclipse Genie

2017-04-05 03:21:25 EDT

Gerrit change https://git.eclipse.org/r/94346 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e0107bc888ee726ae16b294d9bad146b23a7306c

Comment 40 Eclipse Genie

2017-04-05 08:41:56 EDT

New Gerrit change created: https://git.eclipse.org/r/94455

Comment 41 Eclipse Genie

2017-04-06 09:05:28 EDT

New Gerrit change created: https://git.eclipse.org/r/94564

Comment 42 Eclipse Genie

2017-04-06 11:38:28 EDT

Gerrit change https://git.eclipse.org/r/94455 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=100cf8bccaa58c63f8850e1e8b39f90c36c73977

Comment 43 Eclipse Genie

2017-04-07 05:18:04 EDT

Gerrit change https://git.eclipse.org/r/94564 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b6debadf0f92b192f8af2ebebfc019029bfa0225

Comment 44 Eclipse Genie

2017-04-07 11:41:46 EDT

New Gerrit change created: https://git.eclipse.org/r/94687

Comment 45 Eclipse Genie

2017-04-11 03:13:16 EDT

Gerrit change https://git.eclipse.org/r/94687 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=98564daf468c2ee448efe0637c545218c6c9f2d9

Comment 46 Pierre-Charles David

2017-04-14 04:09:19 EDT

Still left to do before this can be closed:
* Improve the Layer label provider to append a " (transient)" suffix in the VSM editor on layers that will be considered transient implicitly (as determined by the nature of their contents).
* Add a default method to the DialectUIServices interface to keep backward compatibility with the previous version of the export() method (which gained a boolean argument in 5.0).
* Complete the documentation regarding the known limitations on model changes which will trigger decorators refresh.

Comment 47 Eclipse Genie

2017-04-25 10:54:07 EDT

New Gerrit change created: https://git.eclipse.org/r/95702

Comment 48 Eclipse Genie

2017-04-26 05:53:29 EDT

New Gerrit change created: https://git.eclipse.org/r/95766

Comment 49 Eclipse Genie

2017-04-27 03:07:53 EDT

New Gerrit change created: https://git.eclipse.org/r/95863

Comment 50 Eclipse Genie

2017-04-27 03:07:56 EDT

New Gerrit change created: https://git.eclipse.org/r/95862

Comment 51 Eclipse Genie

2017-05-05 04:20:45 EDT

Gerrit change https://git.eclipse.org/r/95702 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7b9dc3071382b60b16166be386eb0709b3f48b48

Comment 52 Eclipse Genie

2017-05-05 04:20:47 EDT

Gerrit change https://git.eclipse.org/r/95766 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=17371b4d01e658b35ac85b3498a954f33cdabb70

Comment 53 Eclipse Genie

2017-05-05 04:20:48 EDT

Gerrit change https://git.eclipse.org/r/95863 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ad4113a17b605c548d363eef70fbc4ed549a799b

Comment 54 Eclipse Genie

2017-05-05 04:20:51 EDT

Gerrit change https://git.eclipse.org/r/95862 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d763fe20907663542ced77240f47ada4fcf33582

Comment 55 Laurent Fasani

2017-05-05 06:06:18 EDT

for homologation refer to test files

Comment 56 Eclipse Genie

2017-05-10 03:15:16 EDT

New Gerrit change created: https://git.eclipse.org/r/96698

Comment 57 Eclipse Genie

2017-05-10 10:17:55 EDT

Gerrit change https://git.eclipse.org/r/96698 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=508ac0a00bc745082b470ee57381aa8e510b0cd8

Comment 58 Pierre-Charles David

2017-05-22 09:04:09 EDT

Will be verified as part of the more general acceptance tests (specific items have been added for this new feature in the manual tests).

Comment 59 Pierre-Charles David

2017-06-29 03:33:04 EDT

Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.

Comment 60 Eclipse Genie

2017-08-22 11:46:03 EDT

New Gerrit change created: https://git.eclipse.org/r/103475

Comment 61 Eclipse Genie

2017-08-25 09:52:52 EDT

Gerrit change https://git.eclipse.org/r/103475 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d318854aa942cea691efd02be07263b20eceb057

Comment 62 Eclipse Genie

2017-09-04 09:36:52 EDT

New Gerrit change created: https://git.eclipse.org/r/104283

Comment 63 Eclipse Genie

2017-09-05 03:17:16 EDT

Gerrit change https://git.eclipse.org/r/104283 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0e3344ff0cbc00d691ba1e3a2e6d90d7af910513

Comment 64 Laurent Fasani

2017-09-05 03:18:35 EDT

The bad delete icon in the diagram toolbar has been fixed

Comment 65 Eclipse Genie

2017-09-18 04:35:27 EDT

New Gerrit change created: https://git.eclipse.org/r/105287

Comment 66 Eclipse Genie

2017-09-18 06:47:38 EDT

Gerrit change https://git.eclipse.org/r/105287 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8d8908d80c87eefd38cb1447f64edf214167d932

Comment 67 Eclipse Genie

2017-10-05 10:39:29 EDT

New Gerrit change created: https://git.eclipse.org/r/106298

Comment 68 Laurent Fasani

2017-10-09 05:58:52 EDT

The ticket is reopened because exporting do not contain decorations.

Steps to reproduce
* untick preference Sirius/SiriusDiagram/Printing/Print Decorations
* export a diagram with decorations and tick "export Decorations"
-> KO: the decorations are not visible in the export result
The issue does not occur if preference Sirius/SiriusDiagram/Printing/Print Decorations was unticked

Comment 69 Laurent Fasani

2017-10-09 08:32:23 EDT

As a reminder, the data used for homologation are those of the manual test file

Comment 70 Eclipse Genie

2017-10-10 03:06:26 EDT

Gerrit change https://git.eclipse.org/r/106298 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b0ccfb0011d7279f245ac7dbb1b80aa15147b4ab